Source/core/inspector/JavaScriptCallFrame.h - Issue 1036803002: binidngs: Make callInternalFunction return MaybeLocal

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/inspector/JavaScriptCallFrame.h

Issue 1036803002: binidngs: Make callInternalFunction return MaybeLocal (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/inspector/JavaScriptCallFrame.h

diff --git a/Source/core/inspector/JavaScriptCallFrame.h b/Source/core/inspector/JavaScriptCallFrame.h

index 88355d68b520e63a40e9c5fc01a8608adfdde002..98bafdee4268eab3e4dd57a6ea7d61c9ea4f81db 100644

--- a/Source/core/inspector/JavaScriptCallFrame.h

+++ b/Source/core/inspector/JavaScriptCallFrame.h

@@ -70,7 +70,7 @@ public:

v8::Local<v8::Value> evaluateWithExceptionDetails(v8::Local<v8::Value> expression, v8::Local<v8::Value> scopeExtension);

v8::Local<v8::Value> restart();

- v8::Local<v8::Value> setVariableValue(int scopeNumber, v8::Local<v8::Value> variableName, v8::Local<v8::Value> newValue);

+ v8::MaybeLocal<v8::Value> setVariableValue(int scopeNumber, v8::Local<v8::Value> variableName, v8::Local<v8::Value> newValue);

static v8::Local<v8::Object> createExceptionDetails(v8::Isolate*, v8::Local<v8::Message>);