Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Unified Diff: Source/bindings/core/v8/ScriptRegexp.cpp

Issue 1036803002: binidngs: Make callInternalFunction return MaybeLocal (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/core/v8/ScriptDebugServer.cpp ('k') | Source/bindings/core/v8/V8LazyEventListener.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/core/v8/ScriptRegexp.cpp
diff --git a/Source/bindings/core/v8/ScriptRegexp.cpp b/Source/bindings/core/v8/ScriptRegexp.cpp
index 17656ce4cfb34fe735501d51661cf07480a1e367..9a357a4a54d58eff9a3b2bd6bac04bdd4b55d911 100644
--- a/Source/bindings/core/v8/ScriptRegexp.cpp
+++ b/Source/bindings/core/v8/ScriptRegexp.cpp
@@ -80,9 +80,8 @@ int ScriptRegexp::match(const String& string, int startFrom, int* matchLength) c
if (!regex->Get(context, v8AtomicString(isolate, "exec")).ToLocal(&exec))
return -1;
v8::Local<v8::Value> argv[] = { v8String(isolate, string.substring(startFrom)) };
- v8::Local<v8::Value> returnValue = V8ScriptRunner::callInternalFunction(exec.As<v8::Function>(), regex, WTF_ARRAY_LENGTH(argv), argv, isolate);
-
- if (tryCatch.HasCaught())
+ v8::Local<v8::Value> returnValue;
+ if (!V8ScriptRunner::callInternalFunction(exec.As<v8::Function>(), regex, WTF_ARRAY_LENGTH(argv), argv, isolate).ToLocal(&returnValue))
return -1;
// RegExp#exec returns null if there's no match, otherwise it returns an
« no previous file with comments | « Source/bindings/core/v8/ScriptDebugServer.cpp ('k') | Source/bindings/core/v8/V8LazyEventListener.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698