binidngs: Make callInternalFunction return MaybeLocal

Source/bindings/core/v8/V8ScriptRunner.cpp

Index: Source/bindings/core/v8/V8ScriptRunner.cpp
diff --git a/Source/bindings/core/v8/V8ScriptRunner.cpp b/Source/bindings/core/v8/V8ScriptRunner.cpp
index e8c42f494f26d63b0f409b159c49aaf526320958..dabbd0b8afbe649e3bcf08b70e2967175cdac154 100644
--- a/Source/bindings/core/v8/V8ScriptRunner.cpp
+++ b/Source/bindings/core/v8/V8ScriptRunner.cpp
@@ -479,12 +479,12 @@ v8::Local<v8::Value> V8ScriptRunner::callFunction(v8::Local<v8::Function> functi
     return result;
 }
 
-v8::Local<v8::Value> V8ScriptRunner::callInternalFunction(v8::Local<v8::Function> function, v8::Local<v8::Value> receiver, int argc, v8::Local<v8::Value> args[], v8::Isolate* isolate)
+v8::MaybeLocal<v8::Value> V8ScriptRunner::callInternalFunction(v8::Local<v8::Function> function, v8::Local<v8::Value> receiver, int argc, v8::Local<v8::Value> args[], v8::Isolate* isolate)
 {
     TRACE_EVENT0("v8", "v8.callFunction");
     TRACE_EVENT_SCOPED_SAMPLING_STATE("v8", "V8Execution");
     V8RecursionScope::MicrotaskSuppression recursionScope(isolate);
-    v8::Local<v8::Value> result = function->Call(receiver, argc, args);
+    v8::MaybeLocal<v8::Value> result = function->Call(receiver, argc, args);
     crashIfV8IsDead();

[haraken, 2015/04/01 07:00:32]

BTW, do we still need this check? In a case where crashIfV8IsDead crashes, the
result will be an empty handle.

[bashi, 2015/04/01 07:21:04]

It may be useful given that ToLocalChecked() is DCHECK, while crashIfV8IsDead()
crashes even when we disable assersions.

[haraken, 2015/04/01 07:25:09]

I'm wondering why we have two kinds of ASSERTs. Maybe should we update
ToLocalChecked so that it crashes when an empty handle is returned? (What's a
problem of doing that?)

     return result;
 }