Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Issue 1036783002: Add an implict animation between ActionBar backgrounds (Closed)

Created:
5 years, 9 months ago by abarth-chromium
Modified:
5 years, 9 months ago
Reviewers:
rafaelw, ojan
CC:
mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Add an implict animation between ActionBar backgrounds This CL uses CSS transition to add an implicit animation between purple ActionBar and the light grey "search" action bar. It's unclear to me how best to create implicit animations in this system, but using a CSS transition works surprisingly well. Also, fix the typography style for the placeholder in the search box. Previously it was white on Grey[50], which was extremely hard to see. R=rafaelw@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/82033c3b8377fa31eabcb5151ddc862687a72d9d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M sky/framework/components/action_bar.dart View 1 chunk +1 line, -0 lines 0 comments Download
M sky/framework/components/input.dart View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
abarth-chromium
5 years, 9 months ago (2015-03-25 05:29:30 UTC) #2
rafaelw
lgtm
5 years, 9 months ago (2015-03-25 17:04:15 UTC) #3
abarth-chromium
5 years, 9 months ago (2015-03-25 17:42:46 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
82033c3b8377fa31eabcb5151ddc862687a72d9d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698