Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: test/cctest/test-api.cc

Issue 1036743004: add access checks to receivers on function callbacks (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« src/objects.cc ('K') | « test/cctest/test-accessors.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/test-api.cc
diff --git a/test/cctest/test-api.cc b/test/cctest/test-api.cc
index 0714e404b4fc6386ab0535f952717993c0de87f8..63378ba7d6417453445483ecbc4f40f4189d6653 100644
--- a/test/cctest/test-api.cc
+++ b/test/cctest/test-api.cc
@@ -8279,8 +8279,11 @@ TEST(DetachedAccesses) {
CHECK(result.IsEmpty());
result = CompileRun("get_x_w()");
CHECK(result.IsEmpty());
- result = CompileRun("this_x()");
- CHECK(v8_str("env2_x")->Equals(result));
+ {
+ v8::TryCatch try_catch(env1->GetIsolate());
+ CompileRun("this_x()");
+ CHECK(try_catch.HasCaught());
+ }
// Reattach env2's proxy
env2 = Context::New(env1->GetIsolate(),
« src/objects.cc ('K') | « test/cctest/test-accessors.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698