Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(456)

Unified Diff: src/hydrogen.cc

Issue 1036743004: add access checks to receivers on function callbacks (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/builtins.cc ('k') | src/objects.h » ('j') | src/objects.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/hydrogen.cc
diff --git a/src/hydrogen.cc b/src/hydrogen.cc
index 230939fe56ef6bc639b486f810928af1efaebfd1..bb3b2e8592f93bab32ca8e9623c27083e0f9bb81 100644
--- a/src/hydrogen.cc
+++ b/src/hydrogen.cc
@@ -8659,6 +8659,11 @@ bool HOptimizedGraphBuilder::TryInlineApiCall(Handle<JSFunction> function,
receiver_maps->first(), &holder_lookup);
if (holder_lookup == CallOptimization::kHolderNotFound) return false;
+ // Don't inline calls to receivers requiring accesschecks.
+ for (int i = 0; i < receiver_maps->length(); ++i) {
+ if (receiver_maps->at(i)->is_access_check_needed()) return false;
+ }
+
if (FLAG_trace_inlining) {
PrintF("Inlining api function ");
function->ShortPrint();
« no previous file with comments | « src/builtins.cc ('k') | src/objects.h » ('j') | src/objects.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698