add access checks to receivers on function callbacks

add access checks to receivers on function callbacks

R=verwaest@chromium.org
BUG=468451
LOG=N

Committed: https://crrev.com/a45a1de7aafcc048118a60fdcba8d1d9d8be9fcf
Cr-Commit-Position: refs/heads/master@{#27482}

[dcarney, 2015-03-25 13:07:21]

dcarney@chromium.org changed reviewers:
+ verwaest@chromium.org

[dcarney, 2015-03-25 13:07:31]

ptal

[Toon Verwaest, 2015-03-25 15:28:24]

https://codereview.chromium.org/1036743004/diff/60001/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/1036743004/diff/60001/src/objects.cc#newcode250
src/objects.cc:250: !isolate->MayAccess(js_receiver)) {
This isn't good enough, as the IC you'll compile is available cross-context. If
code from another origin shares the same IC, they'll get access if it was
initialized for the first context. You need to dynamically verify access /
context.

[Toon Verwaest, 2015-03-25 15:31:09]

ok nevermind, lgtm

[dcarney, 2015-03-25 15:54:39]

The CQ bit was checked by dcarney@chromium.org

[dcarney, 2015-03-25 15:54:40]

The patchset sent to the CQ was uploaded after l-g-t-m from
verwaest@chromium.org
Link to the patchset: https://codereview.chromium.org/1036743004/#ps80001
(title: " ")

[commit-bot: I haz the power, 2015-03-25 15:54:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1036743004/80001

[commit-bot: I haz the power, 2015-03-25 16:16:54]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-03-25 16:17:04]

Patchset 5 (id:??) landed as
https://crrev.com/255528710b0a128eef7b66827d9ac43e44650ff4
Cr-Commit-Position: refs/heads/master@{#27452}

[Michael Achenbach, 2015-03-25 18:30:55]

A revert of this CL (patchset #5 id:80001) has been created in
https://codereview.chromium.org/1023783009/ by machenbach@chromium.org.

The reason for reverting is: This seems to lead to lots of timeouts of layout
tests, e.g.:
http://build.chromium.org/p/client.v8/builders/V8-Blink%20Linux%2064/builds/2807.

[Toon Verwaest, 2015-03-26 14:53:27]

lgtm with supernit

https://codereview.chromium.org/1036743004/diff/120001/include/v8.h
File include/v8.h (right):

https://codereview.chromium.org/1036743004/diff/120001/include/v8.h#newcode4188
include/v8.h:4188: *  When set to true, no access check will be performed on the
receiver of a
Remove space before When

[dcarney, 2015-03-26 14:56:45]

The CQ bit was checked by dcarney@chromium.org

[dcarney, 2015-03-26 14:56:46]

The patchset sent to the CQ was uploaded after l-g-t-m from
verwaest@chromium.org
Link to the patchset: https://codereview.chromium.org/1036743004/#ps140001
(title: "super nit")

[commit-bot: I haz the power, 2015-03-26 14:56:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1036743004/140001

[commit-bot: I haz the power, 2015-03-26 15:22:01]

Committed patchset #8 (id:140001)

[commit-bot: I haz the power, 2015-03-26 15:22:22]

Patchset 8 (id:??) landed as
https://crrev.com/a45a1de7aafcc048118a60fdcba8d1d9d8be9fcf
Cr-Commit-Position: refs/heads/master@{#27482}