Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1036743003: Add ServiceWorkerErrorMessage to ServiceWorker DevTool's protocol. (Closed)

Created:
5 years, 9 months ago by horo
Modified:
5 years, 9 months ago
Reviewers:
dgozman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Add ServiceWorkerErrorMessage to ServiceWorker DevTool's protocol. BUG=466871 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192546

Patch Set 1 : #

Total comments: 2

Patch Set 2 : remove ""hidden": true," #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -2 lines) Patch
M Source/devtools/front_end/sdk/ServiceWorkerManager.js View 1 chunk +9 lines, -0 lines 0 comments Download
M Source/devtools/protocol.json View 1 3 chunks +20 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
horo
dgozman@ Could you please review this?
5 years, 9 months ago (2015-03-25 09:49:51 UTC) #3
dgozman
lgtm https://codereview.chromium.org/1036743003/diff/20001/Source/devtools/protocol.json File Source/devtools/protocol.json (right): https://codereview.chromium.org/1036743003/diff/20001/Source/devtools/protocol.json#newcode4104 Source/devtools/protocol.json:4104: "hidden": true, This whole domain is hidden, no ...
5 years, 9 months ago (2015-03-25 11:00:11 UTC) #4
horo
https://codereview.chromium.org/1036743003/diff/20001/Source/devtools/protocol.json File Source/devtools/protocol.json (right): https://codereview.chromium.org/1036743003/diff/20001/Source/devtools/protocol.json#newcode4104 Source/devtools/protocol.json:4104: "hidden": true, On 2015/03/25 11:00:11, dgozman wrote: > This ...
5 years, 9 months ago (2015-03-25 14:26:33 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1036743003/40001
5 years, 9 months ago (2015-03-25 14:26:56 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-03-25 16:20:30 UTC) #9
Message was sent while issue was closed. 
Committed patchset #2 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=192546

Powered by Google App Engine
This is Rietveld 408576698