chrome/browser/chromeos/login/signin/merge_session_xhr_request_waiter.cc - Issue 1036723003: favor DCHECK_CURRENTLY_ON for better logs in chrome/browser/chromeos/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/login/signin/merge_session_xhr_request_waiter.cc

Issue 1036723003: favor DCHECK_CURRENTLY_ON for better logs in chrome/browser/chromeos/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/login/signin/merge_session_throttle.cc ('k') | chrome/browser/chromeos/login/signin/oauth2_login_verifier.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/login/signin/merge_session_xhr_request_waiter.cc

diff --git a/chrome/browser/chromeos/login/signin/merge_session_xhr_request_waiter.cc b/chrome/browser/chromeos/login/signin/merge_session_xhr_request_waiter.cc

index b9a255dda13b68f22b28bdffc6e95b13edfa292f..f3d76db03c360bbb0d2e62e3320899b96d72de1c 100644

--- a/chrome/browser/chromeos/login/signin/merge_session_xhr_request_waiter.cc

+++ b/chrome/browser/chromeos/login/signin/merge_session_xhr_request_waiter.cc

@@ -59,7 +59,7 @@ void MergeSessionXHRRequestWaiter::StartWaiting() {

void MergeSessionXHRRequestWaiter::OnSessionRestoreStateChanged(

Profile* user_profile,

OAuth2LoginManager::SessionRestoreState state) {

- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));

+ DCHECK_CURRENTLY_ON(BrowserThread::UI);

OAuth2LoginManager* manager =

OAuth2LoginManagerFactory::GetInstance()->GetForProfile(profile_);

@@ -81,7 +81,7 @@ void MergeSessionXHRRequestWaiter::OnTimeout() {

}

void MergeSessionXHRRequestWaiter::NotifyBlockingDone() {

- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));

+ DCHECK_CURRENTLY_ON(BrowserThread::UI);

if (!callback_.is_null()) {

BrowserThread::PostTask(

BrowserThread::IO, FROM_HERE, callback_);