chrome/browser/chromeos/drive/file_system/remove_operation.cc - Issue 1036723003: favor DCHECK_CURRENTLY_ON for better logs in chrome/browser/chromeos/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/drive/file_system/remove_operation.cc

Issue 1036723003: favor DCHECK_CURRENTLY_ON for better logs in chrome/browser/chromeos/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/drive/file_system/open_file_operation.cc ('k') | chrome/browser/chromeos/drive/file_system/search_operation.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/drive/file_system/remove_operation.cc

diff --git a/chrome/browser/chromeos/drive/file_system/remove_operation.cc b/chrome/browser/chromeos/drive/file_system/remove_operation.cc

index 9a4b30435e1ccb9b9e07e7d78b58fffc3738b29b..c3f7a1ed80b5fb43670091432f20da9ddfc686bf 100644

--- a/chrome/browser/chromeos/drive/file_system/remove_operation.cc

+++ b/chrome/browser/chromeos/drive/file_system/remove_operation.cc

@@ -70,17 +70,17 @@ RemoveOperation::RemoveOperation(

metadata_(metadata),

cache_(cache),

weak_ptr_factory_(this) {

- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));

+ DCHECK_CURRENTLY_ON(BrowserThread::UI);

}

RemoveOperation::~RemoveOperation() {

- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));

+ DCHECK_CURRENTLY_ON(BrowserThread::UI);

}

void RemoveOperation::Remove(const base::FilePath& path,

bool is_recursive,

const FileOperationCallback& callback) {

- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));

+ DCHECK_CURRENTLY_ON(BrowserThread::UI);

DCHECK(!callback.is_null());

std::string* local_id = new std::string;

@@ -111,7 +111,7 @@ void RemoveOperation::RemoveAfterUpdateLocalState(

const ResourceEntry* entry,

const base::FilePath* changed_path,

FileError error) {

- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));

+ DCHECK_CURRENTLY_ON(BrowserThread::UI);

DCHECK(!callback.is_null());

if (!changed_path->empty()) {