Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issue 1036693002: cc: Fix crash while running blink layout tests with GPU rasterization (Closed)

Created:
5 years, 9 months ago by hendrikw
Modified:
5 years, 9 months ago
Reviewers:
enne (OOO)
CC:
cc-bugs_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Fix crash with blink layout tests and GPU rasterization We were missing the single-threaded task graph runner, which was required for blink's layout tests that checked for pixels. BUG=468928 Committed: https://crrev.com/ae0c69314c5c0025e8e6144f3a7fe64384087c77 Cr-Commit-Position: refs/heads/master@{#322192}

Patch Set 1 #

Patch Set 2 : add comment #

Patch Set 3 : +test #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -11 lines) Patch
M cc/trees/layer_tree_host_impl.cc View 1 3 chunks +11 lines, -11 lines 0 comments Download
M cc/trees/layer_tree_host_pixeltest_synchronous.cc View 1 2 1 chunk +30 lines, -0 lines 1 comment Download

Messages

Total messages: 10 (2 generated)
hendrikw
PTAL, thanks
5 years, 9 months ago (2015-03-24 22:55:34 UTC) #2
enne (OOO)
Do you think it makes sense to add this to the resource pixel tests? Or ...
5 years, 9 months ago (2015-03-24 23:08:55 UTC) #3
hendrikw
On 2015/03/24 23:08:55, enne wrote: > Do you think it makes sense to add this ...
5 years, 9 months ago (2015-03-24 23:13:21 UTC) #4
hendrikw
On 2015/03/24 23:13:21, hendrikw wrote: > On 2015/03/24 23:08:55, enne wrote: > > Do you ...
5 years, 9 months ago (2015-03-25 15:12:32 UTC) #5
enne (OOO)
lgtm https://codereview.chromium.org/1036693002/diff/40001/cc/trees/layer_tree_host_pixeltest_synchronous.cc File cc/trees/layer_tree_host_pixeltest_synchronous.cc (right): https://codereview.chromium.org/1036693002/diff/40001/cc/trees/layer_tree_host_pixeltest_synchronous.cc#newcode47 cc/trees/layer_tree_host_pixeltest_synchronous.cc:47: class LayerTreeHostSynchronousGPUPixelTest : public LayerTreePixelTest { Ooh, perfect. ...
5 years, 9 months ago (2015-03-25 17:10:22 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1036693002/40001
5 years, 9 months ago (2015-03-25 17:10:59 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 9 months ago (2015-03-25 18:16:25 UTC) #9
commit-bot: I haz the power
5 years, 9 months ago (2015-03-25 18:19:53 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/ae0c69314c5c0025e8e6144f3a7fe64384087c77
Cr-Commit-Position: refs/heads/master@{#322192}

Powered by Google App Engine
This is Rietveld 408576698