Break runs by clusters rather than iteration over code points

ui/gfx/render_text_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/gfx/render_text.h"
 
 #include <algorithm>
 
 #include "base/format_macros.h"
 #include "base/i18n/break_iterator.h"
@@ skipping 2559 matching lines @@
   EXPECT_EQ(Range(0, 0), run.CharRangeToGlyphRange(Range(4, 5)));
   EXPECT_EQ(Range(0, 0),
             internal::RoundRangeF(run.GetGraphemeBounds(iter.get(), 4)));
   Range chars;
   Range glyphs;
   run.GetClusterAt(4, &chars, &glyphs);
   EXPECT_EQ(Range(3, 8), chars);
   EXPECT_EQ(Range(0, 0), glyphs);
 }
 
+// Ensure the line breaker doesn't compute the word's width bigger than the
+// actual size. See http://crbug.com/470073
+TEST_F(RenderTextTest, HarfBuzz_WordWidthWithDiacritics) {
+  RenderTextHarfBuzz render_text;
+  const base::string16 kWord = WideToUTF16(L"\u0906\u092A\u0915\u0947 ");
+  render_text.SetText(kWord);
+  gfx::SizeF text_size = render_text.GetStringSizeF();

[msw, 2015/03/25 20:25:16]

nit: const

[Jun Mukai, 2015/03/25 21:50:05]

Done.

+
+  render_text.SetText(kWord + kWord);

[msw, 2015/03/25 20:25:16]

nit: after this, but before SetDisplayRect, can you test something like:
  EXPECT_EQ(text_size.width() * 2, render_text.GetStringSizeF().width());

[Jun Mukai, 2015/03/25 21:50:05]

Done.

+  render_text.SetMultiline(true);
+  render_text.SetDisplayRect(gfx::Rect(0, 0, text_size.width(), 0));

[msw, 2015/03/25 20:25:16]

nit: instead of setting the display rect, can you add a '\n' char?

[Jun Mukai, 2015/03/25 21:50:05]

'\n' doesn't work well in this case, since RTHB splits the text into different
runs, this CL wants to verify the line breaks in a run.

[msw, 2015/03/25 22:51:44]

Acknowledged.

+  EXPECT_EQ(text_size.width(), render_text.GetStringSizeF().width());
+  EXPECT_EQ(text_size.height() * 2, render_text.GetStringSizeF().height());
+}
+
 // Ensure a string fits in a display rect with a width equal to the string's.
 TEST_F(RenderTextTest, StringFitsOwnWidth) {
   scoped_ptr<RenderText> render_text(RenderText::CreateInstance());
   const base::string16 kString = ASCIIToUTF16("www.example.com");
 
   render_text->SetText(kString);
   render_text->ApplyStyle(BOLD, true, Range(0, 3));
   render_text->SetElideBehavior(ELIDE_TAIL);
 
   render_text->SetDisplayRect(Rect(0, 0, 500, 100));
@@ skipping 232 matching lines @@
   string_size.set_width(string_size.width() / 2);
   render_text.SetDisplayRect(gfx::Rect(string_size));
   render_text.EnsureLayout();
   CFIndex glyph_count = CTLineGetGlyphCount(render_text.line_);
   EXPECT_GT(text.size(), static_cast<size_t>(glyph_count));
   EXPECT_NE(0, glyph_count);
 }
 #endif
 
 }  // namespace gfx