Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Issue 1036653004: Use rtc::Buffer::size() instead of rtc::Buffer::length() (Closed)

Created:
5 years, 9 months ago by kwiberg-chromium
Modified:
5 years, 9 months ago
Reviewers:
perkj_chrome
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use rtc::Buffer::size() instead of rtc::Buffer::length() The latter is just a backwards-compatibility redirect to the former, and I'm hoping to get rid of it. Committed: https://crrev.com/8c4e8a9b19c909ca40fb0c7a674d22203e597c6a Cr-Commit-Position: refs/heads/master@{#322473}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M content/renderer/media/rtc_data_channel_handler.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
kwiberg-chromium
5 years, 9 months ago (2015-03-26 13:07:42 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1036653004/1
5 years, 9 months ago (2015-03-26 15:50:00 UTC) #4
perkj_chrome
On 2015/03/26 13:07:42, kwiberg wrote: lgtm
5 years, 9 months ago (2015-03-26 15:50:00 UTC) #5
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 9 months ago (2015-03-26 15:50:02 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1036653004/1
5 years, 9 months ago (2015-03-26 19:37:45 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1036653004/1
5 years, 9 months ago (2015-03-26 19:41:36 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-26 21:22:09 UTC) #13
commit-bot: I haz the power
5 years, 9 months ago (2015-03-26 21:22:56 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8c4e8a9b19c909ca40fb0c7a674d22203e597c6a
Cr-Commit-Position: refs/heads/master@{#322473}

Powered by Google App Engine
This is Rietveld 408576698