Issue 1036643003: Change the QuicInMemoryCache to store a SpdyHeaderBlock instead of BalsaHeaders.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1036643003: Change the QuicInMemoryCache to store a SpdyHeaderBlock instead of BalsaHeaders. (Closed)

Created:
5 years, 9 months ago by Ryan Hamilton

Modified:
5 years, 9 months ago

Reviewers:
ramant (doing other things)

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Change the QuicInMemoryCache to store a SpdyHeaderBlock instead of BalsaHeaders. This saves various round trips between the two representations and will make it easier to port to Chromium which does not use BalsaHeader (in the main codebase). Merge internal change: 89410736 R=rtenneti@chromium.org BUG=

Patch Set 1 #

Total comments: 2

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+56 lines, -66 lines)			Patch
M	net/data/quic_in_memory_cache_data/quic-datatesturl.com/index.html	View	1 chunk	+1 line, -1 line	0 comments	Download
M	net/tools/quic/quic_in_memory_cache.h	View	5 chunks	+11 lines, -13 lines	0 comments	Download
M	net/tools/quic/quic_in_memory_cache.cc	View	6 chunks	+19 lines, -10 lines	0 comments	Download
M	net/tools/quic/quic_in_memory_cache_test.cc	View	4 chunks	+11 lines, -8 lines	0 comments	Download
M	net/tools/quic/quic_spdy_server_stream.h	View	2 chunks	+3 lines, -1 line	2 comments	Download
M	net/tools/quic/quic_spdy_server_stream.cc	View	2 chunks	+6 lines, -10 lines	0 comments	Download
M	net/tools/quic/quic_spdy_server_stream_test.cc	View	1 chunk	+5 lines, -23 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ramant (doing other things)

lgtm https://codereview.chromium.org/1036643003/diff/1/net/tools/quic/quic_spdy_server_stream.h File net/tools/quic/quic_spdy_server_stream.h (right): https://codereview.chromium.org/1036643003/diff/1/net/tools/quic/quic_spdy_server_stream.h#newcode52 net/tools/quic/quic_spdy_server_stream.h:52: nit: extra blank line

5 years, 9 months ago (2015-03-24 21:30:11 UTC) #2

Ryan Hamilton

5 years, 9 months ago (2015-03-24 22:02:38 UTC) #3

Thanks!

https://codereview.chromium.org/1036643003/diff/1/net/tools/quic/quic_spdy_se...
File net/tools/quic/quic_spdy_server_stream.h (right):

https://codereview.chromium.org/1036643003/diff/1/net/tools/quic/quic_spdy_se...
net/tools/quic/quic_spdy_server_stream.h:52: 
On 2015/03/24 21:30:11, ramant wrote:
> nit: extra blank line

Done. (In final CL)

Expand Messages | Collapse Messages