Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(937)

Issue 1036593004: [Extension API Extern Generation] Add support for function types (Closed)

Created:
5 years, 9 months ago by Devlin
Modified:
5 years, 9 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, Tyler Breisacher (Chromium)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Extension API Extern Generation] Add support for function types Instead of just having Function or Function= for each callback, use the function() Closure Compiler type documentation. Additionally, add support for @deprecated function documentation. BUG=461039 Committed: https://crrev.com/7fbd4963fddcac58bf29762d85e96b42562e5c64 Cr-Commit-Position: refs/heads/master@{#322285}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -24 lines) Patch
M tools/json_schema_compiler/js_externs_generator.py View 2 chunks +28 lines, -20 lines 0 comments Download
M tools/json_schema_compiler/js_externs_generator_test.py View 2 chunks +23 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Devlin
Dan, please take a look when you can. Tyler, just FYI.
5 years, 9 months ago (2015-03-25 16:17:41 UTC) #3
Dan Beam
lgtm++
5 years, 9 months ago (2015-03-25 23:27:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1036593004/20001
5 years, 9 months ago (2015-03-25 23:38:51 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:20001)
5 years, 9 months ago (2015-03-26 01:07:27 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-26 01:08:02 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7fbd4963fddcac58bf29762d85e96b42562e5c64
Cr-Commit-Position: refs/heads/master@{#322285}

Powered by Google App Engine
This is Rietveld 408576698