Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Issue 1036563002: Simplify callback style in DomDistiller tests (Closed)

Created:
5 years, 9 months ago by wychen
Modified:
5 years, 5 months ago
Reviewers:
nyquist
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Simplify callback style in DomDistiller tests Committed: https://crrev.com/3d636120ebd9b0c549af0d7677d9936cab6f8c65 Cr-Commit-Position: refs/heads/master@{#338365}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M components/dom_distiller/content/distiller_page_web_contents_browsertest.cc View 1 2 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
wychen
PTAL
5 years, 5 months ago (2015-07-08 21:33:37 UTC) #2
nyquist
lgtm
5 years, 5 months ago (2015-07-08 21:50:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1036563002/20001
5 years, 5 months ago (2015-07-10 21:04:03 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 5 months ago (2015-07-10 21:30:11 UTC) #6
commit-bot: I haz the power
5 years, 5 months ago (2015-07-10 21:31:17 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3d636120ebd9b0c549af0d7677d9936cab6f8c65
Cr-Commit-Position: refs/heads/master@{#338365}

Powered by Google App Engine
This is Rietveld 408576698