Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 1036533003: Add a go-fast button to Skia GYP configs. (Closed)

Created:
5 years, 9 months ago by mtklein_C
Modified:
5 years, 9 months ago
Reviewers:
mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add a go-fast button to Skia GYP configs. ./gyp_skia -Dskia_fast=1 will - always optimize for the current machine as much as possible - drop the frame pointer - optimize floating point arithmetic ignoring IEEE compliance This allows things like 3-argument VEX prefix SSE instructions and NEON autovectorization, and can give some seriously helpful clues about how to rearrange floating point math for speed. I've been having trouble with LTO linking, so I'll leave that out for now. I don't think we should set up bots with this mode. -ffast-math means I'm forced to run DM with --match ~Blend ~Path ~Rect ~Math ~Scalar ~Matrix ~Point before it passes, which is a disconcerting chunk of tests to disable (including all of PathOps). BUG=skia: Committed: https://skia.googlesource.com/skia/+/dee3df930b83751577d5a3489d402c0c9e284495

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M gyp/common_conditions.gypi View 1 3 chunks +3 lines, -0 lines 0 comments Download
M gyp/common_variables.gypi View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
mtklein_C
5 years, 9 months ago (2015-03-25 14:29:02 UTC) #2
mtklein
lgtm
5 years, 9 months ago (2015-03-26 12:21:27 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1036533003/1
5 years, 9 months ago (2015-03-26 12:21:33 UTC) #6
commit-bot: I haz the power
Failed to apply patch for gyp/common_conditions.gypi: While running git apply --index -3 -p1; error: patch ...
5 years, 9 months ago (2015-03-26 12:21:36 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1036533003/20001
5 years, 9 months ago (2015-03-26 12:23:59 UTC) #11
commit-bot: I haz the power
5 years, 9 months ago (2015-03-26 12:30:47 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/dee3df930b83751577d5a3489d402c0c9e284495

Powered by Google App Engine
This is Rietveld 408576698