Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 1036533002: Redirect chrome://welcome to the new tab page. (Closed)

Created:
5 years, 9 months ago by newt (away)
Modified:
5 years, 9 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Redirect chrome://welcome to the new tab page. The welcome page was removed in M40. Users who had the welcome page open when upgrading from pre-M40 to post-M40 will see a "webpage not available" error after the upgrade. This fixes that behavior by replacing the welcome page with an NTP. BUG=455427 Committed: https://crrev.com/4bdfb4b68b800911adb3d36d64e841fa6ec5757a Cr-Commit-Position: refs/heads/master@{#322049}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -8 lines) Patch
M chrome/browser/android/new_tab_page_url_handler.cc View 2 chunks +9 lines, -4 lines 0 comments Download
M chrome/common/url_constants.h View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
newt (away)
PTAL
5 years, 9 months ago (2015-03-24 18:28:17 UTC) #2
Ted C
lgtm
5 years, 9 months ago (2015-03-24 18:38:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1036533002/1
5 years, 9 months ago (2015-03-24 18:39:22 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-24 19:40:08 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-24 19:40:40 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4bdfb4b68b800911adb3d36d64e841fa6ec5757a
Cr-Commit-Position: refs/heads/master@{#322049}

Powered by Google App Engine
This is Rietveld 408576698