Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1036523002: Switch DM to use utils/android/SkAndroidSDKCanvas (Closed)

Created:
5 years, 9 months ago by tomhudson
Modified:
5 years, 9 months ago
Reviewers:
djsollen
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Switch DM to use utils/android/SkAndroidSDKCanvas Use (better) paint filter shared with nanobench, instead of custom implementation. R=djsollen@google.com Committed: https://skia.googlesource.com/skia/+/48dc6dc52ecfcc1e0cfd75f637d55c03e4d6bcb2

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove redundant gyp include #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -199 lines) Patch
M dm/DMSrcSinkAndroid.cpp View 3 chunks +3 lines, -199 lines 0 comments Download
M gyp/dm.gyp View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
tomhudson
Moved from Android code review system.
5 years, 9 months ago (2015-03-24 17:50:50 UTC) #1
djsollen
https://codereview.chromium.org/1036523002/diff/1/gyp/dm.gyp File gyp/dm.gyp (right): https://codereview.chromium.org/1036523002/diff/1/gyp/dm.gyp#newcode23 gyp/dm.gyp:23: '../src/utils/android/', you shouldn't need this as it will be ...
5 years, 9 months ago (2015-03-24 18:02:55 UTC) #2
tomhudson
https://codereview.chromium.org/1036523002/diff/1/gyp/dm.gyp File gyp/dm.gyp (right): https://codereview.chromium.org/1036523002/diff/1/gyp/dm.gyp#newcode23 gyp/dm.gyp:23: '../src/utils/android/', On 2015/03/24 18:02:55, djsollen wrote: > you shouldn't ...
5 years, 9 months ago (2015-03-24 19:33:08 UTC) #3
djsollen
lgtm
5 years, 9 months ago (2015-03-24 19:34:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1036523002/20001
5 years, 9 months ago (2015-03-24 19:41:43 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-24 19:46:43 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/48dc6dc52ecfcc1e0cfd75f637d55c03e4d6bcb2

Powered by Google App Engine
This is Rietveld 408576698