Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 1036513005: Revert of Build the IRT with nacl-clang for x86 (Closed)

Created:
5 years, 9 months ago by Derek Schuff
Modified:
5 years, 9 months ago
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/src/native_client.git@master
Target Ref:
refs/heads/master
Project:
nacl
Visibility:
Public.

Description

Revert of Build the IRT with nacl-clang for x86 (patchset #16 id:290001 of https://codereview.chromium.org/940993003/) Reason for revert: F%*$^ windows XP Original issue's description: > Build the IRT with nacl-clang for x86 > > This should result in faster builds, and in the future could > allow cleanups of the IRT-building gyp code and the PNaCl drivers. > > * Use -mstackrealign and -mno-sse to be callable with under-aligned stacks. > * Use -integrated-as to ensure sandbox base address hiding on x86-64. > * Uses -fno-exceptions to reduce the size, and links with > PNaCl's unwind stubs to avoid including the unwinder (which > would otherwise be pulled in by libcxx). > * Remove -gline-tables-only which was a workaround for > slowness and excessive memory consumption in bitcode linking > * Also use nacl-clang for the SCons core IRT build. > > BUG= https://code.google.com/p/nativeclient/issues/detail?id=4088 > R=jvoung@chromium.org, mseaborn@chromium.org > > Committed: https://chromium.googlesource.com/native_client/src/native_client/+/316f3e53bfcc34e4a137abbce02d890e3ea968ce TBR=jvoung@chromium.org,mseaborn@chromium.org,mcgrathr@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= https://code.google.com/p/nativeclient/issues/detail?id=4088 Committed: https://chromium.googlesource.com/native_client/src/native_client/+/70e1707b52d1740660479fc7e83cf250445cb6e1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -109 lines) Patch
M SConstruct View 3 chunks +27 lines, -23 lines 0 comments Download
M build/untrusted.gypi View 12 chunks +25 lines, -36 lines 0 comments Download
D src/untrusted/irt/frame_info_stubs.c View 1 chunk +0 lines, -17 lines 0 comments Download
M src/untrusted/irt/irt.gyp View 2 chunks +1 line, -22 lines 0 comments Download
M toolchain_build/pnacl_sandboxed_translator.py View 3 chunks +3 lines, -11 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Derek Schuff
Created Revert of Build the IRT with nacl-clang for x86
5 years, 9 months ago (2015-03-25 22:45:22 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1036513005/1
5 years, 9 months ago (2015-03-25 22:45:47 UTC) #2
commit-bot: I haz the power
5 years, 9 months ago (2015-03-25 22:46:00 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/native_client/src/native_client/+/70e1707b5...

Powered by Google App Engine
This is Rietveld 408576698