Add CHROMECAST_EXPORT definition for OEM shlib replacement

Add CHROMECAST_EXPORT definition for OEM shlib replacement

Needed for exposing graphics API to shared library replacement.

BUG=

Committed: https://crrev.com/52fe462e2ae38d8f34540aa057c4cb9329341789
Cr-Commit-Position: refs/heads/master@{#322096}

[halliwell, 2015-03-24 20:26:40]

halliwell@chromium.org changed reviewers:
+ byungchul@chromium.org, gunsch@chromium.org

[byungchul, 2015-03-24 21:06:10]

lgtm

https://codereview.chromium.org/1036503003/diff/1/chromecast/chromecast.gyp
File chromecast/chromecast.gyp (right):

https://codereview.chromium.org/1036503003/diff/1/chromecast/chromecast.gyp#n...
chromecast/chromecast.gyp:37: 
extra blank line

[halliwell, 2015-03-24 21:19:56]

https://codereview.chromium.org/1036503003/diff/1/chromecast/chromecast.gyp
File chromecast/chromecast.gyp (right):

https://codereview.chromium.org/1036503003/diff/1/chromecast/chromecast.gyp#n...
chromecast/chromecast.gyp:37: 
On 2015/03/24 21:06:10, byungchul wrote:
> extra blank line

Done.

[gunsch, 2015-03-24 21:27:04]

I'm all for having a chromecast/public dir and a cast_public_api target, but
let's make the file "chromecast/chromecast_export.h" for consistency with other
targets.
(https://code.google.com/p/chromium/codesearch#search/&q=file:_export.h)

[halliwell, 2015-03-24 21:33:06]

On 2015/03/24 21:27:04, gunsch wrote:
> I'm all for having a chromecast/public dir and a cast_public_api target, but
> let's make the file "chromecast/chromecast_export.h" for consistency with
other
> targets.
> (https://code.google.com/p/chromium/codesearch#search/&q=file:_export.h)

Done.

[byungchul, 2015-03-24 21:37:10]

On 2015/03/24 21:27:04, gunsch wrote:
> I'm all for having a chromecast/public dir and a cast_public_api target, but
> let's make the file "chromecast/chromecast_export.h" for consistency with
other
> targets.
> (https://code.google.com/p/chromium/codesearch#search/&q=file:_export.h)

I don't think it makes sense since *_export.h is for the case when components ==
shared_library. This chromecast_export.h is not for the case. Note that /chrome
doesn't have chrome_export.h because it is a final executable.
I am fine to change the filename instead.

[byungchul, 2015-03-24 21:37:12]

On 2015/03/24 21:27:04, gunsch wrote:
> I'm all for having a chromecast/public dir and a cast_public_api target, but
> let's make the file "chromecast/chromecast_export.h" for consistency with
other
> targets.
> (https://code.google.com/p/chromium/codesearch#search/&q=file:_export.h)

I don't think it makes sense since *_export.h is for the case when components ==
shared_library. This chromecast_export.h is not for the case. Note that /chrome
doesn't have chrome_export.h because it is a final executable.
I am fine to change the filename instead.

[gunsch, 2015-03-24 21:48:00]

Hm, that's a good point. I guess I'm fine with it in either location (and maybe
public/ is better in that case), but it might be worth extra docs in the
chromecast_export.h header to indicate that it has a different purpose than most
of the *export.h headers in chromium.

https://codereview.chromium.org/1036503003/diff/40001/chromecast/chromecast_e...
File chromecast/chromecast_export.h (right):

https://codereview.chromium.org/1036503003/diff/40001/chromecast/chromecast_e...
chromecast/chromecast_export.h:5: #ifndef CHROMECAST_PUBLIC_CHROMECAST_EXPORT_H_
update this to match wherever the file ends up

[halliwell, 2015-03-24 21:56:48]

On 2015/03/24 21:48:00, gunsch wrote:
> Hm, that's a good point. I guess I'm fine with it in either location (and
maybe
> public/ is better in that case), but it might be worth extra docs in the
> chromecast_export.h header to indicate that it has a different purpose than
most
> of the *export.h headers in chromium.
> 
>
https://codereview.chromium.org/1036503003/diff/40001/chromecast/chromecast_e...
> File chromecast/chromecast_export.h (right):
> 
>
https://codereview.chromium.org/1036503003/diff/40001/chromecast/chromecast_e...
> chromecast/chromecast_export.h:5: #ifndef
CHROMECAST_PUBLIC_CHROMECAST_EXPORT_H_
> update this to match wherever the file ends up

Ok, moved back to public with a comment.

[gunsch, 2015-03-24 22:03:33]

lgtm

[halliwell, 2015-03-24 22:04:43]

The CQ bit was checked by halliwell@chromium.org

[halliwell, 2015-03-24 22:04:44]

The patchset sent to the CQ was uploaded after l-g-t-m from
byungchul@chromium.org
Link to the patchset: https://codereview.chromium.org/1036503003/#ps60001
(title: "Moved back to public and added comment.")

[commit-bot: I haz the power, 2015-03-24 22:05:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1036503003/60001

[commit-bot: I haz the power, 2015-03-24 23:54:27]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-03-24 23:55:05]

Patchset 4 (id:??) landed as
https://crrev.com/52fe462e2ae38d8f34540aa057c4cb9329341789
Cr-Commit-Position: refs/heads/master@{#322096}