Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 1036453002: PPC: Fix 'PPC: Serializer: serialize internal references via object visitor.' (Closed)

Created:
5 years, 9 months ago by michael_dawson
Modified:
5 years, 9 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: Fix 'PPC: Serializer: serialize internal references via object visitor.' Port 56d2ee0310972119ec47810ee03a4f7077f7117e Original commit message: R=mbrandy@us.ibm.com BUG= Committed: https://crrev.com/052020e514bb56aa2c5f8ff116d47a5a1f4e447a Cr-Commit-Position: refs/heads/master@{#27428}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M src/ppc/assembler-ppc.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/ppc/assembler-ppc-inl.h View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
michael_dawson
next ppc port
5 years, 9 months ago (2015-03-24 13:48:25 UTC) #1
MTBrandyberry
On 2015/03/24 13:48:25, michael_dawson wrote: > next ppc port lgtm
5 years, 9 months ago (2015-03-24 13:53:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1036453002/1
5 years, 9 months ago (2015-03-24 13:57:53 UTC) #4
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 9 months ago (2015-03-24 13:57:54 UTC) #6
Sven Panne
Hmmm, something is not working yet. Michael?
5 years, 9 months ago (2015-03-24 14:00:27 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1036453002/1
5 years, 9 months ago (2015-03-24 22:17:50 UTC) #10
Michael Achenbach
I hit the CQ once more. Now it seems to work. Maybe that committer change ...
5 years, 9 months ago (2015-03-24 22:20:57 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-25 06:40:08 UTC) #12
commit-bot: I haz the power
5 years, 9 months ago (2015-03-25 06:40:16 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/052020e514bb56aa2c5f8ff116d47a5a1f4e447a
Cr-Commit-Position: refs/heads/master@{#27428}

Powered by Google App Engine
This is Rietveld 408576698