Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 1036423002: Convert svg/text/columns-do-not-apply.html to a reftest. (Closed)

Created:
5 years, 9 months ago by mstensho (USE GERRIT)
Modified:
5 years, 8 months ago
CC:
blink-reviews
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

Convert svg/text/columns-do-not-apply.html to a reftest. Also increase column count to 4, to increase the likelihood of this failing if the code is broken. BUG=471172 R=ed@opera.com Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192932

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -93 lines) Patch
M LayoutTests/TestExpectations View 1 chunk +0 lines, -3 lines 0 comments Download
D LayoutTests/platform/linux/svg/text/columns-do-not-apply-expected.png View Binary file 0 comments Download
D LayoutTests/platform/linux/svg/text/columns-do-not-apply-expected.txt View 1 chunk +0 lines, -11 lines 0 comments Download
D LayoutTests/platform/linux/virtual/slimmingpaint/svg/text/columns-do-not-apply-expected.png View Binary file 0 comments Download
D LayoutTests/platform/linux/virtual/slimmingpaint/svg/text/columns-do-not-apply-expected.txt View 1 chunk +0 lines, -11 lines 0 comments Download
D LayoutTests/platform/mac/svg/text/columns-do-not-apply-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac/svg/text/columns-do-not-apply-expected.txt View 1 chunk +0 lines, -11 lines 0 comments Download
D LayoutTests/platform/mac/virtual/slimmingpaint/svg/text/columns-do-not-apply-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac/virtual/slimmingpaint/svg/text/columns-do-not-apply-expected.txt View 1 chunk +0 lines, -11 lines 0 comments Download
D LayoutTests/platform/win-xp/svg/text/columns-do-not-apply-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win-xp/svg/text/columns-do-not-apply-expected.txt View 1 chunk +0 lines, -11 lines 0 comments Download
D LayoutTests/platform/win-xp/virtual/slimmingpaint/svg/text/columns-do-not-apply-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win-xp/virtual/slimmingpaint/svg/text/columns-do-not-apply-expected.txt View 1 chunk +0 lines, -11 lines 0 comments Download
D LayoutTests/platform/win/svg/text/columns-do-not-apply-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/svg/text/columns-do-not-apply-expected.txt View 1 chunk +0 lines, -11 lines 0 comments Download
D LayoutTests/platform/win/virtual/slimmingpaint/svg/text/columns-do-not-apply-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/virtual/slimmingpaint/svg/text/columns-do-not-apply-expected.txt View 1 chunk +0 lines, -11 lines 0 comments Download
M LayoutTests/svg/text/columns-do-not-apply.html View 1 chunk +1 line, -1 line 0 comments Download
A + LayoutTests/svg/text/columns-do-not-apply-expected.html View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
mstensho (USE GERRIT)
5 years, 9 months ago (2015-03-27 18:18:54 UTC) #1
Erik Dahlström (inactive)
lgtm
5 years, 8 months ago (2015-03-30 07:02:43 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1036423002/1
5 years, 8 months ago (2015-04-01 07:56:04 UTC) #4
commit-bot: I haz the power
5 years, 8 months ago (2015-04-01 13:06:02 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=192932

Powered by Google App Engine
This is Rietveld 408576698