Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 1036403003: Update MojoShell's target APK version to 23. (Closed)

Created:
5 years, 9 months ago by tonyg
Modified:
5 years, 8 months ago
Reviewers:
qsr, eseidel
CC:
eseidel, alhaad, jamesr, mojo-reviews_chromium.org, qsr+mojo_chromium.org, yzshen+watch_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Update MojoShell's target APK version to 23. This allows the network service to work when running on Wear. TBR=qsr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/63e7d660840380a4e1bf55f48bbb44407c751b41

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M shell/android/apk/AndroidManifest.xml View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (6 generated)
tonyg
[+eseidel] I know that qsr is the best reviewer for this, but I'd rather not ...
5 years, 8 months ago (2015-03-30 15:41:30 UTC) #3
tonyg
Committed patchset #1 (id:1) manually as 63e7d660840380a4e1bf55f48bbb44407c751b41 (presubmit successful).
5 years, 8 months ago (2015-03-30 16:17:57 UTC) #7
eseidel
5 years, 8 months ago (2015-03-31 13:21:44 UTC) #9
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698