Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2890)

Unified Diff: chrome/browser/ui/views/frame/top_container_view.cc

Issue 1036403002: views: Move TopContainerView paint recursion to PaintChildren. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: topcontainerview: . Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/views/frame/top_container_view.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/frame/top_container_view.cc
diff --git a/chrome/browser/ui/views/frame/top_container_view.cc b/chrome/browser/ui/views/frame/top_container_view.cc
index e36d6084b0012172d602c20fb2edda4e060454eb..f623fc191290a16c54bccbff330978fdce3442f7 100644
--- a/chrome/browser/ui/views/frame/top_container_view.cc
+++ b/chrome/browser/ui/views/frame/top_container_view.cc
@@ -19,12 +19,16 @@ const char* TopContainerView::GetClassName() const {
return "TopContainerView";
}
-void TopContainerView::OnPaintBackground(gfx::Canvas* canvas) {
+void TopContainerView::PaintChildren(gfx::Canvas* canvas,
+ const views::CullSet& cull_set) {
if (browser_view_->immersive_mode_controller()->IsRevealed()) {
// Top-views depend on parts of the frame (themes, window title,
// window controls) being painted underneath them. Clip rect has already
// been set to the bounds of this view, so just paint the frame.
views::View* frame = browser_view_->frame()->GetFrameView();
+ // Use an empty CullSet as we're painting something outside of the normal
+ // parent-child relationship that the CullSet would understand.
frame->Paint(canvas, views::CullSet());
}
+ View::PaintChildren(canvas, cull_set);
}
« no previous file with comments | « chrome/browser/ui/views/frame/top_container_view.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698