views: Move TopContainerView paint recursion to PaintChildren.

views: Move TopContainerView paint recursion to PaintChildren.

Currently this class recurses to browser_view_->frame()->GetFrameView()
in OnPaintBackground. Instead, do this recursion in PaintChildren
so that it has access to the the recursion data to be passed through
PaintChildren.

R=sky
BUG=466426
Committed: https://crrev.com/bdc4b62d9366cd45d082192793c000386d9bb3f1
Cr-Commit-Position: refs/heads/master@{#322663}

[danakj, 2015-03-27 18:10:07]

Ran an ash window in immersive mode and verified the drop-in controls still look
the same.

[danakj, 2015-03-27 18:50:58]

https://codereview.chromium.org/1036403002/diff/1/chrome/browser/ui/views/fra...
File chrome/browser/ui/views/frame/top_container_view.cc (right):

https://codereview.chromium.org/1036403002/diff/1/chrome/browser/ui/views/fra...
chrome/browser/ui/views/frame/top_container_view.cc:29: frame->Paint(canvas,
cull_set);
One question, is it okay to pass thru the same cull_set here? Or would that give
wrong results due to frame not actually being a child? It is still painting by
inspection, but I'm not sure how frame would end up in the cull_set. Is it
somewhere in the tree?

[danakj, 2015-03-27 19:17:26]

https://codereview.chromium.org/1036403002/diff/1/chrome/browser/ui/views/fra...
File chrome/browser/ui/views/frame/top_container_view.cc (right):

https://codereview.chromium.org/1036403002/diff/1/chrome/browser/ui/views/fra...
chrome/browser/ui/views/frame/top_container_view.cc:29: frame->Paint(canvas,
cull_set);
On 2015/03/27 18:50:58, danakj wrote:
> One question, is it okay to pass thru the same cull_set here? Or would that
give
> wrong results due to frame not actually being a child? It is still painting by
> inspection, but I'm not sure how frame would end up in the cull_set. Is it
> somewhere in the tree?

I see, the CullSet is empty here. This is due to it being promoted into a layer
out of the aura::Window. When we're in immersivemode the CullSet is not used for
anything in the top controls stuff.

I'm going to change this back to passin an explicitly empty CullSet though
still.

[sky, 2015-03-27 21:19:42]

LGTM

[danakj, 2015-03-27 21:28:36]

The CQ bit was checked by danakj@chromium.org

[commit-bot: I haz the power, 2015-03-27 21:29:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1036403002/20001

[commit-bot: I haz the power, 2015-03-27 21:42:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-27 21:42:24]

Try jobs failed on following builders:
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[danakj, 2015-03-27 21:45:09]

The CQ bit was checked by danakj@chromium.org

[danakj, 2015-03-27 21:45:10]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/1036403002/#ps40001
(title: "topcontainerview: .")

[commit-bot: I haz the power, 2015-03-27 21:45:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1036403002/40001

[commit-bot: I haz the power, 2015-03-27 22:43:04]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-03-27 22:44:05]

Patchset 3 (id:??) landed as
https://crrev.com/bdc4b62d9366cd45d082192793c000386d9bb3f1
Cr-Commit-Position: refs/heads/master@{#322663}