Mark the functions of closures generated to speed up getField/setField as invisible, just like othe…

runtime/lib/mirrors.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "lib/mirrors.h"
 
 #include "lib/invocation_mirror.h"
 #include "vm/bootstrap_natives.h"
 #include "vm/class_finalizer.h"
 #include "vm/compiler.h"
@@ skipping 1220 matching lines @@
   }
   ASSERT(!ctxt_library.IsNull());
   const Object& result =
      Object::Handle(ctxt_library.Evaluate(expression,
                                           Array::empty_array(),
                                           Array::empty_array()));
   if (result.IsError()) {
     Exceptions::PropagateError(Error::Cast(result));
     UNREACHABLE();
   }
+
+  // Because we currently only use this native for building field extractors and
+  // setters, assume the result is a closure and mark its function as invisible,
+  // so it will not appear in stack traces. Whenever we support
+  // ObjectMirror.evaluate this will need to be separated.
+  ASSERT(Instance::Cast(result).IsClosure());
+  const Function& func =
+      Function::Handle(Closure::function(Instance::Cast(result)));
+  func.set_is_visible(false);
+  func.set_is_debuggable(false);
+
   return result.raw();
 }
 
 DEFINE_NATIVE_ENTRY(TypedefMirror_declaration, 1) {
   GET_NON_NULL_NATIVE_ARGUMENT(Type, type, arguments->NativeArgAt(0));
   const Class& cls = Class::Handle(type.type_class());
   // We represent typedefs as non-canonical signature classes.
   ASSERT(cls.IsSignatureClass() && !cls.IsCanonicalSignatureClass());
   return CreateTypedefMirror(cls,
                              AbstractType::Handle(cls.DeclarationType()),
@@ skipping 785 matching lines @@
 }
 
 DEFINE_NATIVE_ENTRY(TypeMirror_moreSpecificTest, 2) {
   GET_NON_NULL_NATIVE_ARGUMENT(AbstractType, a, arguments->NativeArgAt(0));
   GET_NON_NULL_NATIVE_ARGUMENT(AbstractType, b, arguments->NativeArgAt(1));
   return Bool::Get(a.IsMoreSpecificThan(b, NULL)).raw();
 }
 
 
 }  // namespace dart