Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 1036363002: Reland of "precache: Move the java files into //components/precache/android" (Closed)

Created:
5 years, 8 months ago by sadrul
Modified:
5 years, 8 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of "precache: Move the java files into //components/precache/android" The CL was previously reverted in crrev.com/322355 because it broke downstream android builds. This is a straight-forward reland of the original issue. A fix will be landed for downstream once this CL lands. Original issue's description: > > precache: Move the java files into //components/precache/android > > > > This moves code out of //java/apps/chrome/.../precache into: > > . //components/precache/android/: classes that provide information about > > device-state, network connectivity etc. > > . //chrome/android/.../precache/: precache service and service launchers. > > > > BUG=401552 TBR=bengr@chromium.org,yfriedman@chromium.org,thestig@chromium.org,alexclarke@chromium.org NOPRESUBMIT=true BUG=401552 Committed: https://crrev.com/819a04e83a9ce6231577237656b0790914f24982 Cr-Commit-Position: refs/heads/master@{#322605}

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1405 lines, -10 lines) Patch
M chrome/android/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/android/java/DEPS View 1 1 chunk +1 line, -0 lines 0 comments Download
A chrome/android/java/src/org/chromium/chrome/browser/precache/PrecacheLauncher.java View 1 1 chunk +95 lines, -0 lines 0 comments Download
A chrome/android/java/src/org/chromium/chrome/browser/precache/PrecacheService.java View 1 1 chunk +211 lines, -0 lines 0 comments Download
A chrome/android/java/src/org/chromium/chrome/browser/precache/PrecacheServiceLauncher.java View 1 1 chunk +223 lines, -0 lines 0 comments Download
M chrome/android/javatests/DEPS View 1 1 chunk +1 line, -0 lines 0 comments Download
A chrome/android/javatests/src/org/chromium/chrome/browser/precache/MockPrecacheService.java View 1 1 chunk +13 lines, -0 lines 0 comments Download
A chrome/android/javatests/src/org/chromium/chrome/browser/precache/PrecacheServiceLauncherTest.java View 1 1 chunk +143 lines, -0 lines 0 comments Download
A chrome/android/javatests/src/org/chromium/chrome/browser/precache/PrecacheServiceTest.java View 1 1 chunk +132 lines, -0 lines 0 comments Download
M chrome/android/shell/java/AndroidManifest.xml.jinja2 View 1 2 chunks +11 lines, -2 lines 0 comments Download
M chrome/browser/android/chrome_jni_registrar.cc View 1 2 chunks +2 lines, -0 lines 0 comments Download
A chrome/browser/android/precache/precache_launcher.h View 1 1 chunk +37 lines, -0 lines 0 comments Download
A chrome/browser/android/precache/precache_launcher.cc View 1 1 chunk +108 lines, -0 lines 0 comments Download
M chrome/chrome.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 chunks +3 lines, -0 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 1 chunk +1 line, -0 lines 0 comments Download
M components/precache.gypi View 1 1 chunk +27 lines, -0 lines 0 comments Download
A + components/precache/android/BUILD.gn View 1 1 chunk +10 lines, -8 lines 0 comments Download
A components/precache/android/java/src/org/chromium/components/precache/DeviceState.java View 1 1 chunk +79 lines, -0 lines 0 comments Download
A components/precache/android/java/src/org/chromium/components/precache/NetworkInfoDelegate.java View 1 1 chunk +61 lines, -0 lines 0 comments Download
A components/precache/android/java/src/org/chromium/components/precache/NetworkInfoDelegateFactory.java View 1 1 chunk +16 lines, -0 lines 0 comments Download
A components/precache/android/javatests/src/org/chromium/components/precache/DeviceStateTest.java View 1 1 chunk +184 lines, -0 lines 0 comments Download
A components/precache/android/javatests/src/org/chromium/components/precache/MockDeviceState.java View 1 1 chunk +45 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
sadrul
Created Revert of Revert of precache: Move the java files into //components/precache/android
5 years, 8 months ago (2015-03-27 17:10:20 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1036363002/1
5 years, 8 months ago (2015-03-27 17:10:55 UTC) #2
commit-bot: I haz the power
Failed to apply patch for chrome/android/shell/java/AndroidManifest.xml.jinja2: While running git apply --index -3 -p1; error: patch ...
5 years, 8 months ago (2015-03-27 17:11:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1036363002/280001
5 years, 8 months ago (2015-03-27 17:19:02 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:280001)
5 years, 8 months ago (2015-03-27 18:18:36 UTC) #8
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/819a04e83a9ce6231577237656b0790914f24982 Cr-Commit-Position: refs/heads/master@{#322605}
5 years, 8 months ago (2015-03-27 18:19:31 UTC) #9
sadrul
5 years, 8 months ago (2015-03-27 18:40:37 UTC) #10
Message was sent while issue was closed.
On 2015/03/27 18:19:31, I haz the power (commit-bot) wrote:
> Patchset 2 (id:??) landed as
> https://crrev.com/819a04e83a9ce6231577237656b0790914f24982
> Cr-Commit-Position: refs/heads/master@{#322605}

Heads up to anyone looking at possible downstream failure: the fix for
downstream is in the CQ:
https://chrome-internal-review.googlesource.com/#/c/210206/

Powered by Google App Engine
This is Rietveld 408576698