content/browser/frame_host/render_frame_host_manager.cc - Issue 103633002: Add RenderFrameHostDelegate and plumb it through all the necessary classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/render_frame_host_manager.cc

Issue 103633002: Add RenderFrameHostDelegate and plumb it through all the necessary classes. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/frame_host/render_frame_host_manager.h ('k') | content/browser/frame_host/render_frame_host_manager_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/frame_host/render_frame_host_manager.cc

===================================================================

--- content/browser/frame_host/render_frame_host_manager.cc (revision 238504)

+++ content/browser/frame_host/render_frame_host_manager.cc (working copy)

@@ -57,11 +57,13 @@

RenderFrameHostManager::PendingNavigationParams::~PendingNavigationParams() {}

RenderFrameHostManager::RenderFrameHostManager(

+ RenderFrameHostDelegate* render_frame_delegate,

RenderViewHostDelegate* render_view_delegate,

RenderWidgetHostDelegate* render_widget_delegate,

Delegate* delegate)

: delegate_(delegate),

cross_navigation_pending_(false),

+ render_frame_delegate_(render_frame_delegate),

render_view_delegate_(render_view_delegate),

render_widget_delegate_(render_widget_delegate),

render_view_host_(NULL),

@@ -98,8 +100,8 @@

site_instance = SiteInstance::Create(browser_context);

render_view_host_ = static_cast<RenderViewHostImpl*>(

RenderViewHostFactory::Create(

- site_instance, render_view_delegate_, render_widget_delegate_,

- routing_id, main_frame_routing_id, false,

+ site_instance, render_view_delegate_, render_frame_delegate_,

+ render_widget_delegate_, routing_id, main_frame_routing_id, false,

delegate_->IsHidden()));

render_view_host_->AttachToFrameTree();

@@ -745,6 +747,7 @@

new_render_view_host = static_cast<RenderViewHostImpl*>(

RenderViewHostFactory::Create(instance,

render_view_delegate_,

+ render_frame_delegate_,

render_widget_delegate_,

MSG_ROUTING_NONE,