Issue 1036303002: Move HWUI boilerplate into utils/android

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1036303002: Move HWUI boilerplate into utils/android (Closed)

Created:
5 years, 9 months ago by tomhudson

Modified:
5 years, 9 months ago

Reviewers:
djsollen, mtklein

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

Move HWUI boilerplate into utils/android Duplicate code from the HWUI backends for DM and nanobench moves into a single place, saving a hundred lines or more of cut-and-paste. There's some indication that this increases the incidence of SkCanvas "Unable to find device for layer." warnings, but no clear degradation in test results. R=djsollen@google.com,mtklein@google.com BUG=skia:3589 Committed: https://skia.googlesource.com/skia/+/573ae01295241c156ff8548ded283d44864d22d2

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+52 lines, -342 lines)			Patch
M	bench/nanobenchAndroid.h	View	2 chunks	+2 lines, -19 lines	0 comments	Download
M	bench/nanobenchAndroid.cpp	View	2 chunks	+9 lines, -111 lines	0 comments	Download
M	dm/DMSrcSinkAndroid.cpp	View	1 chunk	+8 lines, -144 lines	0 comments	Download
M	gyp/utils.gyp	View	1 chunk	+2 lines, -0 lines	0 comments	Download
A +	src/utils/android/SkHwuiRenderer.h	View	2 chunks	+12 lines, -19 lines	0 comments	Download
A +	src/utils/android/SkHwuiRenderer.cpp	View	4 chunks	+19 lines, -49 lines	0 comments	Download

Total messages: 6 (1 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1036303002/1

5 years, 9 months ago (2015-03-27 16:57:20 UTC) #5

commit-bot: I haz the power

5 years, 9 months ago (2015-03-27 19:22:08 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/573ae01295241c156ff8548ded283d44864d22d2