Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 1036283002: Remove all code related to NaCl (Closed)

Created:
5 years, 8 months ago by borenet
Modified:
5 years, 8 months ago
Reviewers:
scroggo, djsollen, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Fix typo #

Patch Set 3 : Rebase #

Patch Set 4 : Fix ifdev, add missing copyright info #

Patch Set 5 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+100 lines, -2311 lines) Patch
M dm/DM.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M gyp/SampleApp.gyp View 1 chunk +0 lines, -5 lines 0 comments Download
M gyp/apptype_console.gypi View 1 chunk +0 lines, -5 lines 0 comments Download
M gyp/common.gypi View 2 chunks +0 lines, -4 lines 0 comments Download
M gyp/common_conditions.gypi View 1 2 3 4 4 chunks +2 lines, -29 lines 0 comments Download
M gyp/common_variables.gypi View 1 2 3 1 chunk +1 line, -4 lines 0 comments Download
M gyp/debugger.gyp View 2 chunks +61 lines, -84 lines 0 comments Download
M gyp/freetype.gyp View 1 chunk +2 lines, -2 lines 0 comments Download
M gyp/gpu.gyp View 2 chunks +1 line, -12 lines 0 comments Download
M gyp/gpu.gypi View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M gyp/images.gyp View 1 2 1 chunk +0 lines, -12 lines 0 comments Download
D gyp/nacl.gyp View 1 chunk +0 lines, -23 lines 0 comments Download
M gyp/ports.gyp View 1 2 3 3 chunks +1 line, -14 lines 0 comments Download
M gyp/tools.gyp View 2 chunks +4 lines, -15 lines 0 comments Download
M gyp/utils.gyp View 1 2 1 chunk +0 lines, -8 lines 0 comments Download
M gyp/views.gyp View 2 chunks +0 lines, -12 lines 0 comments Download
M include/core/SkPostConfig.h View 1 chunk +1 line, -1 line 0 comments Download
M include/core/SkPreConfig.h View 1 chunk +1 line, -1 line 0 comments Download
D include/views/SkOSWindow_NaCl.h View 1 chunk +0 lines, -43 lines 0 comments Download
M include/views/SkWindow.h View 1 chunk +1 line, -3 lines 0 comments Download
D platform_tools/nacl/SampleApp/SampleApp.nmf View 1 chunk +0 lines, -6 lines 0 comments Download
D platform_tools/nacl/SampleApp/index.html View 1 chunk +0 lines, -71 lines 0 comments Download
D platform_tools/nacl/debugger/debugger.css View 1 chunk +0 lines, -172 lines 0 comments Download
D platform_tools/nacl/debugger/debugger.nmf View 1 chunk +0 lines, -6 lines 0 comments Download
D platform_tools/nacl/debugger/icons/blank.png View Binary file 0 comments Download
D platform_tools/nacl/debugger/icons/breakpoint.png View Binary file 0 comments Download
D platform_tools/nacl/debugger/icons/breakpoint_16x16.png View Binary file 0 comments Download
D platform_tools/nacl/debugger/icons/delete.png View Binary file 0 comments Download
D platform_tools/nacl/debugger/icons/inspector.png View Binary file 0 comments Download
D platform_tools/nacl/debugger/icons/next.png View Binary file 0 comments Download
D platform_tools/nacl/debugger/icons/pause.png View Binary file 0 comments Download
D platform_tools/nacl/debugger/icons/play.png View Binary file 0 comments Download
D platform_tools/nacl/debugger/icons/previous.png View Binary file 0 comments Download
D platform_tools/nacl/debugger/icons/profile.png View Binary file 0 comments Download
D platform_tools/nacl/debugger/icons/reload.png View Binary file 0 comments Download
D platform_tools/nacl/debugger/icons/rewind.png View Binary file 0 comments Download
D platform_tools/nacl/debugger/icons/skia.png View Binary file 0 comments Download
D platform_tools/nacl/debugger/index.html View 1 chunk +0 lines, -468 lines 0 comments Download
D platform_tools/nacl/favicon.ico View Binary file 0 comments Download
D platform_tools/nacl/httpd.py View 1 chunk +0 lines, -212 lines 0 comments Download
D platform_tools/nacl/index.html View 1 chunk +0 lines, -23 lines 0 comments Download
D platform_tools/nacl/nacl_make View 1 chunk +0 lines, -115 lines 0 comments Download
D platform_tools/nacl/skhello/index.html View 1 chunk +0 lines, -71 lines 0 comments Download
D platform_tools/nacl/skhello/skhello.nmf View 1 chunk +0 lines, -6 lines 0 comments Download
D platform_tools/nacl/src/nacl_debugger.cpp View 1 chunk +0 lines, -219 lines 0 comments Download
D platform_tools/nacl/src/nacl_hello.cpp View 1 chunk +0 lines, -150 lines 0 comments Download
D platform_tools/nacl/src/nacl_interface.cpp View 1 chunk +0 lines, -111 lines 0 comments Download
D platform_tools/nacl/src/nacl_sample.cpp View 1 chunk +0 lines, -212 lines 0 comments Download
D platform_tools/nacl/tests/index.html View 1 chunk +0 lines, -78 lines 0 comments Download
D platform_tools/nacl/tests/tests.nmf View 1 chunk +0 lines, -6 lines 0 comments Download
M site/dev/contrib/c++11.md View 1 chunk +1 line, -5 lines 0 comments Download
M site/dev/contrib/cqkeywords.md View 1 chunk +1 line, -1 line 0 comments Download
D site/user/quick/nacl.md View 1 chunk +0 lines, -93 lines 0 comments Download
M src/images/SkForceLinking.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M tests/PathOpsSkpClipTest.cpp View 1 2 3 2 chunks +8 lines, -1 line 0 comments Download
M tests/skia_test.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tools/CrashHandler.cpp View 1 2 3 3 chunks +9 lines, -2 lines 0 comments Download
M tools/skpdiff/skpdiff_main.cpp View 1 2 3 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 22 (10 generated)
borenet
5 years, 8 months ago (2015-03-27 15:25:38 UTC) #2
scroggo
On 2015/03/27 15:25:38, borenet wrote: LGTM. Thanks, Lennie.
5 years, 8 months ago (2015-03-27 15:41:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1036283002/1
5 years, 8 months ago (2015-03-27 19:15:20 UTC) #5
commit-bot: I haz the power
Presubmit check for 1036283002-1 failed and returned exit status 1. Running presubmit commit checks ...
5 years, 8 months ago (2015-03-27 19:15:38 UTC) #7
borenet
5 years, 8 months ago (2015-03-27 19:16:13 UTC) #9
scroggo
Derek, can you approve this? It has some changes in include, so we need API ...
5 years, 8 months ago (2015-03-30 14:50:38 UTC) #11
mtklein
On 2015/03/30 14:50:38, scroggo wrote: > Derek, can you approve this? It has some changes ...
5 years, 8 months ago (2015-03-30 15:08:39 UTC) #12
djsollen
api lgtm
5 years, 8 months ago (2015-03-30 15:10:13 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1036283002/40001
5 years, 8 months ago (2015-03-30 15:11:32 UTC) #16
commit-bot: I haz the power
Presubmit check for 1036283002-40001 failed and returned exit status 1. Running presubmit commit checks ...
5 years, 8 months ago (2015-03-30 15:11:51 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1036283002/80001
5 years, 8 months ago (2015-04-02 19:09:26 UTC) #21
commit-bot: I haz the power
5 years, 8 months ago (2015-04-02 19:16:41 UTC) #22
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/4808757d7a8bbe8c773a312a894738e9ff701b5f

Powered by Google App Engine
This is Rietveld 408576698