Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Issue 1036273002: Sync the DataTransfer* interfaces with the spec (Closed)

Created:
5 years, 9 months ago by philipj_slow
Modified:
5 years, 9 months ago
Reviewers:
Jens Widell, dcheng
CC:
dcheng, arv+blink, blink-reviews, Inactive, vivekg_samsung, vivekg
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

Sync the DataTransfer* interfaces with the spec The only change to the generated code is due to DataTransferItemList.length now being unsigned long, but since will not be observable as DataTransferItemList::length() will not return any negative values. BUG=460722 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192697

Patch Set 1 #

Total comments: 2

Patch Set 2 : link to getAsFile() bug #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -17 lines) Patch
M Source/core/clipboard/DataTransfer.idl View 1 chunk +13 lines, -9 lines 0 comments Download
M Source/core/clipboard/DataTransferItem.idl View 1 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/clipboard/DataTransferItemList.idl View 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
philipj_slow
PTAL
5 years, 9 months ago (2015-03-27 14:59:41 UTC) #2
dcheng
FWIW, LGTM. Thanks for updating this. https://codereview.chromium.org/1036273002/diff/1/Source/core/clipboard/DataTransferItem.idl File Source/core/clipboard/DataTransferItem.idl (right): https://codereview.chromium.org/1036273002/diff/1/Source/core/clipboard/DataTransferItem.idl#newcode40 Source/core/clipboard/DataTransferItem.idl:40: // TODO(philipj): getAsFile() ...
5 years, 9 months ago (2015-03-27 15:02:33 UTC) #4
Jens Widell
LGTM
5 years, 9 months ago (2015-03-27 15:06:30 UTC) #5
philipj_slow
link to getAsFile() bug
5 years, 9 months ago (2015-03-27 17:59:58 UTC) #6
philipj_slow
https://codereview.chromium.org/1036273002/diff/1/Source/core/clipboard/DataTransferItem.idl File Source/core/clipboard/DataTransferItem.idl (right): https://codereview.chromium.org/1036273002/diff/1/Source/core/clipboard/DataTransferItem.idl#newcode40 Source/core/clipboard/DataTransferItem.idl:40: // TODO(philipj): getAsFile() should return a File, not a ...
5 years, 9 months ago (2015-03-27 18:00:07 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1036273002/20001
5 years, 9 months ago (2015-03-27 18:00:46 UTC) #10
commit-bot: I haz the power
5 years, 9 months ago (2015-03-27 19:37:51 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=192697

Powered by Google App Engine
This is Rietveld 408576698