Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1167)

Issue 1036263003: hi-dpi: convert _NET_WORKAREA from pixels. (Closed)

Created:
5 years, 9 months ago by stapelberg
Modified:
5 years, 8 months ago
Reviewers:
sadrul
CC:
chromium-reviews, tfarina, tdanderson+views_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

hi-dpi: convert _NET_WORKAREA from pixels. Just like the gfx::Display member |bounds_| is not stored in pixels, we need to convert |work_area_| from pixels. Both are used in MenuController::UpdateInitialLocation (|work_area_| is preferred over |bounds_|), which gets events with already converted coordinates. BUG=469373, 143619 Committed: https://crrev.com/717c2773a86fb7ec73c3b77e9048fd541c3cf876 Cr-Commit-Position: refs/heads/master@{#322724}

Patch Set 1 #

Total comments: 4

Patch Set 2 : hi-dpi: convert _NET_WORKAREA from pixels. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -5 lines) Patch
M ui/views/widget/desktop_aura/desktop_screen_x11.cc View 1 3 chunks +15 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
stapelberg
5 years, 9 months ago (2015-03-28 16:53:00 UTC) #2
sadrul
Good find! Thanks for the fix! A couple of nits, other than that, lgtm https://codereview.chromium.org/1036263003/diff/1/ui/views/widget/desktop_aura/desktop_screen_x11.cc ...
5 years, 9 months ago (2015-03-28 22:26:03 UTC) #3
stapelberg
https://codereview.chromium.org/1036263003/diff/1/ui/views/widget/desktop_aura/desktop_screen_x11.cc File ui/views/widget/desktop_aura/desktop_screen_x11.cc (right): https://codereview.chromium.org/1036263003/diff/1/ui/views/widget/desktop_aura/desktop_screen_x11.cc#newcode272 ui/views/widget/desktop_aura/desktop_screen_x11.cc:272: gfx::Rect work_area; On 2015/03/28 22:26:02, sadrul wrote: > Mind ...
5 years, 8 months ago (2015-03-29 14:37:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1036263003/20001
5 years, 8 months ago (2015-03-29 14:37:50 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-03-29 15:12:10 UTC) #8
commit-bot: I haz the power
5 years, 8 months ago (2015-03-29 15:12:41 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/717c2773a86fb7ec73c3b77e9048fd541c3cf876
Cr-Commit-Position: refs/heads/master@{#322724}

Powered by Google App Engine
This is Rietveld 408576698