PlzNavigate: Improvements to RFHM commit logic.

content/browser/frame_host/render_frame_host_manager_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/command_line.h"
 #include "base/files/file_path.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/test/histogram_tester.h"
 #include "base/time/time.h"
 #include "content/browser/frame_host/cross_site_transferring_request.h"
@@ skipping 1058 matching lines @@
     EXPECT_TRUE(manager2->speculative_web_ui());
   } else {
     EXPECT_TRUE(manager2->pending_web_ui());
   }
   EXPECT_TRUE(
       host2->render_view_host()->GetEnabledBindings() & BINDINGS_POLICY_WEB_UI);
 
   manager2->DidNavigateFrame(host2, true);
 }
 
+// Tests that a WebUI is correctly reused between chrome:// pages.
+TEST_F(RenderFrameHostManagerTest, WebUIWasReused) {
+  set_should_create_webui(true);
+
+  // Navigate to a WebUI page.
+  const GURL kUrl1("chrome://foo");
+  contents()->NavigateAndCommit(kUrl1);
+  RenderFrameHostManager* manager =
+      main_test_rfh()->frame_tree_node()->render_manager();
+  WebUIImpl* web_ui = manager->web_ui();
+  EXPECT_TRUE(web_ui);
+
+  // Navigate to another WebUI page which should be same-site and keep the
+  // current WebUI.
+  const GURL kUrl2("chrome://foo/bar");
+  contents()->NavigateAndCommit(kUrl2);
+  EXPECT_EQ(web_ui, manager->web_ui());
+}
+
+// Tests that a WebUI is correctly cleaned up when navigating from a chrome://
+// page to a non-chrome:// page.
+TEST_F(RenderFrameHostManagerTest, WebUIWasCleared) {
+  set_should_create_webui(true);
+
+  // Navigate to a WebUI page.
+  const GURL kUrl1("chrome://foo");
+  contents()->NavigateAndCommit(kUrl1);
+  EXPECT_TRUE(main_test_rfh()->frame_tree_node()->render_manager()->web_ui());
+
+  // Navigate to a non-WebUI page.
+  const GURL kUrl2("http://www.google.com");
+  contents()->NavigateAndCommit(kUrl2);
+  EXPECT_FALSE(main_test_rfh()->frame_tree_node()->render_manager()->web_ui());
+}
+
 // Tests that we don't end up in an inconsistent state if a page does a back and
 // then reload. http://crbug.com/51680
 // Also tests that only user-gesture navigations can interrupt cross-process
 // navigations. http://crbug.com/75195
 TEST_F(RenderFrameHostManagerTest, PageDoesBackAndReload) {
   const GURL kUrl1("http://www.google.com/");
   const GURL kUrl2("http://www.evil-site.com/");
 
   // Navigate to a safe site, then an evil site.
   // This will switch RenderFrameHosts.  We cannot assert that the first and
@@ skipping 929 matching lines @@
   EXPECT_FALSE(contents2->GetMainFrame()->IsRenderFrameLive());
   contents2->NavigateAndCommit(kUrl3);
   EXPECT_TRUE(contents2->GetMainFrame()->IsRenderFrameLive());
   EXPECT_NE(nullptr,
             iframe->GetRenderFrameProxyHost(contents1->GetSiteInstance()));
   EXPECT_EQ(nullptr,
             iframe->GetRenderFrameProxyHost(contents2->GetSiteInstance()));
 }
 
 }  // namespace content