Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(598)

Issue 1036243002: Roll tools/swarming_client/ to 13e7c88b5a9494467259603486f001694ea85721. (Closed)

Created:
5 years, 9 months ago by M-A Ruel
Modified:
5 years, 9 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/a/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll tools/swarming_client/ to 13e7c88b5a9494467259603486f001694ea85721. $ git log 53ef01328..13e7c88b5 --date=short --format='%ad %ae %s' | sed 's/@chromium\.org//' 2015-03-26 maruel Add bot_delete command and add DELETE support to utils/net. 2015-03-24 maruel Print a proper error when the target directory exists. 2015-03-23 vadimsh Do not import oauth2client.crypt since it fails on bots. 2015-03-23 maruel Fix enumeration when using '&' in the url. 2015-03-23 maruel Do not print an exception if stdout is closed early. 2015-03-20 vadimsh Add support for service account. 2015-03-20 vadimsh Simplify authentication related code. 2015-03-20 maruel Do not hang if a grand children outlives the children process. Add whitelist for pyasn1, it's BSD licensed. Add whitelist for rsa, it's Apache v2.0 licensed. R=vadimsh@chromium.org,phajdan.jr@chromium.org,thestig@chromium.org BUG=471372 Committed: https://crrev.com/934aaca0ff32eaa834bea1a3fd5792e52e2710e5 Cr-Commit-Position: refs/heads/master@{#322674}

Patch Set 1 #

Patch Set 2 : Fix checklicenses #

Patch Set 3 : Needed third_party/rsa too, I had missed in #

Patch Set 4 : Refer 471372 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M tools/checklicenses/checklicenses.py View 1 2 3 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (4 generated)
M-A Ruel
5 years, 9 months ago (2015-03-27 13:49:52 UTC) #1
M-A Ruel
Add whitelist for pyasn1, add Pawel for OWNERS of checklicenses.py.
5 years, 9 months ago (2015-03-27 18:09:54 UTC) #3
Vadim Sh.
lgtm thanks, I always forget about license check..
5 years, 9 months ago (2015-03-27 20:01:20 UTC) #4
M-A Ruel
On 2015/03/27 20:01:20, Vadim Sh. wrote: > lgtm > > thanks, I always forget about ...
5 years, 9 months ago (2015-03-27 20:36:22 UTC) #6
Lei Zhang
Is the issue that the third party code you are pulling in missing some license ...
5 years, 9 months ago (2015-03-27 20:53:09 UTC) #7
Lei Zhang
On 2015/03/27 20:53:09, Lei Zhang wrote: > Is the issue that the third party code ...
5 years, 9 months ago (2015-03-27 20:57:54 UTC) #8
M-A Ruel
On 2015/03/27 20:57:54, Lei Zhang wrote: > On 2015/03/27 20:53:09, Lei Zhang wrote: > > ...
5 years, 9 months ago (2015-03-27 21:11:11 UTC) #9
Lei Zhang
On 2015/03/27 21:11:11, M-A Ruel wrote: > On 2015/03/27 20:57:54, Lei Zhang wrote: > > ...
5 years, 9 months ago (2015-03-27 21:14:53 UTC) #10
M-A Ruel
On 2015/03/27 21:14:53, Lei Zhang wrote: > Can you file a bug so whoever has ...
5 years, 9 months ago (2015-03-27 21:28:45 UTC) #11
Lei Zhang
lgtm
5 years, 9 months ago (2015-03-27 21:28:49 UTC) #12
M-A Ruel
And added reference to the bug in checklicenses.py
5 years, 9 months ago (2015-03-27 21:29:02 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1036243002/60001
5 years, 9 months ago (2015-03-27 21:30:54 UTC) #16
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 9 months ago (2015-03-27 23:22:11 UTC) #17
commit-bot: I haz the power
5 years, 9 months ago (2015-03-27 23:23:58 UTC) #18
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/934aaca0ff32eaa834bea1a3fd5792e52e2710e5
Cr-Commit-Position: refs/heads/master@{#322674}

Powered by Google App Engine
This is Rietveld 408576698