Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 1036233006: Issue 20144. Reset propagated type if one of the 'if' branches changes it to a different one. (Closed)

Created:
5 years, 9 months ago by scheglov
Modified:
5 years, 9 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Issue 20144. Reset propagated type if one of the 'if' branches changes it to a different one. R=brianwilkerson@google.com BUG= https://code.google.com/p/dart/issues/detail?id=20144 Committed: https://code.google.com/p/dart/source/detail?r=44754

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -9 lines) Patch
M pkg/analyzer/lib/src/generated/resolver.dart View 4 chunks +36 lines, -6 lines 0 comments Download
M pkg/analyzer/test/generated/resolver_test.dart View 2 chunks +49 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
5 years, 9 months ago (2015-03-27 18:54:31 UTC) #1
Brian Wilkerson
LGTM
5 years, 9 months ago (2015-03-27 19:09:26 UTC) #2
scheglov
5 years, 9 months ago (2015-03-27 19:13:56 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 44754 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698