Allow views::Label subclasses create RenderText

Allow views::Label subclasses create RenderText

BUG=

Committed: https://crrev.com/618219d5e2bbfc306a3302ddf0bb93554bbf64cb
Cr-Commit-Position: refs/heads/master@{#322787}

[Tomasz Moniuszko, 2015-03-27 16:09:36]

tmoniuszko@opera.com changed reviewers:
+ sky@chromium.org

[Tomasz Moniuszko, 2015-03-27 16:15:58]

Hello,

Will you accept such kind of patch? It's sometimes useful if Label subclass is
able to create RenderText (or change properties of the instance created by the
base class).

[sky, 2015-03-27 18:31:19]

sky@chromium.org changed reviewers:
+ msw@chromium.org

[sky, 2015-03-27 18:31:19]

RenderText is an implementation detail and I don't think it should be exposed.
What specifically did you want to change on it?

[Tomasz Moniuszko, 2015-03-30 10:05:20]

On 2015/03/27 18:31:19, sky wrote:
> RenderText is an implementation detail and I don't think it should be exposed.
> What specifically did you want to change on it?

RenderText is an abstract model. I think Label shouldn't be sticked to its
particular implementation. It should be open for extending. For instance we
would like Label subclass to support some more advanced fade effect. If we have
RenderText implementation that supports fade shader customization then the only
thing we need is to instantiate and initialize this implementation from
LabelSubclass::CreateRenderText(). It's hard to extend Label if we are not able
to extend its drawing possibilities.

[sky, 2015-03-30 15:00:48]

Fair enough, move the implementation to match and LGTM

[Tomasz Moniuszko, 2015-03-30 15:15:05]

The CQ bit was checked by tmoniuszko@opera.com

[Tomasz Moniuszko, 2015-03-30 15:15:05]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/1036233005/#ps20001
(title: "Move implementation to match")

[commit-bot: I haz the power, 2015-03-30 15:15:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1036233005/20001

[commit-bot: I haz the power, 2015-03-30 16:02:39]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-03-30 16:03:24]

Patchset 2 (id:??) landed as
https://crrev.com/618219d5e2bbfc306a3302ddf0bb93554bbf64cb
Cr-Commit-Position: refs/heads/master@{#322787}