Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 1036213002: [DevTools] Remove support for old /json/new (Closed)

Created:
5 years, 9 months ago by vkuzkokov
Modified:
5 years, 9 months ago
Reviewers:
dgozman
CC:
chromium-reviews, aandrey+blink_chromium.org, yurys, pfeldman, devtools-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Remove support for old /json/new BUG=471204 Committed: https://crrev.com/d7aaa9e08cb9b96f8aeb642f2653d04d163ee092 Cr-Commit-Position: refs/heads/master@{#322567}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -83 lines) Patch
M chrome/browser/devtools/device/devtools_android_bridge.h View 1 chunk +0 lines, -12 lines 0 comments Download
M chrome/browser/devtools/device/devtools_android_bridge.cc View 4 chunks +6 lines, -71 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
vkuzkokov
5 years, 9 months ago (2015-03-27 11:15:45 UTC) #2
dgozman
This needs a bug with detailed description on why it's safe to remove.
5 years, 9 months ago (2015-03-27 11:41:44 UTC) #3
vkuzkokov
On 2015/03/27 11:41:44, dgozman wrote: > This needs a bug with detailed description on why ...
5 years, 9 months ago (2015-03-27 12:06:50 UTC) #4
dgozman
lgtm
5 years, 9 months ago (2015-03-27 12:25:49 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1036213002/1
5 years, 9 months ago (2015-03-27 12:29:33 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-27 13:16:37 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-03-27 13:17:15 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d7aaa9e08cb9b96f8aeb642f2653d04d163ee092
Cr-Commit-Position: refs/heads/master@{#322567}

Powered by Google App Engine
This is Rietveld 408576698