Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Issue 1036183002: Changed "Learn more" URL for history page. (Closed)

Created:
5 years, 9 months ago by pkl (ping after 24h if needed)
Modified:
5 years, 9 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Changed "Learn more" URL for history page. BUG=469773 TEST=Bring up History page and verify Learn more link goes to the right page. Check different UI languages as well. TBR=cpu@chromium.org Committed: https://crrev.com/648b1afdc60aa6cc0e4b009bb13e3c26d0fa4e34 Cr-Commit-Position: refs/heads/master@{#322550}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
pkl (ping after 24h if needed)
5 years, 9 months ago (2015-03-27 09:25:31 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1036183002/1
5 years, 9 months ago (2015-03-27 09:25:45 UTC) #4
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 9 months ago (2015-03-27 09:25:47 UTC) #6
pkl (ping after 24h if needed)
R=droger TBR=cpu
5 years, 9 months ago (2015-03-27 09:26:22 UTC) #8
droger
lgtm
5 years, 9 months ago (2015-03-27 09:46:27 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1036183002/1
5 years, 9 months ago (2015-03-27 09:46:57 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-27 11:04:12 UTC) #12
commit-bot: I haz the power
5 years, 9 months ago (2015-03-27 11:05:39 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/648b1afdc60aa6cc0e4b009bb13e3c26d0fa4e34
Cr-Commit-Position: refs/heads/master@{#322550}

Powered by Google App Engine
This is Rietveld 408576698