chrome/browser/ui/views/frame/browser_view.h - Issue 1036173002: Animate showing / hiding the location bar for bookmark apps.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/frame/browser_view.h

Issue 1036173002: Animate showing / hiding the location bar for bookmark apps. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Mac compile Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/extensions/bookmark_app_browser_controller.cc ('K') | « chrome/browser/ui/location_bar/location_bar.h ('k') | chrome/browser/ui/views/frame/browser_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/frame/browser_view.h

diff --git a/chrome/browser/ui/views/frame/browser_view.h b/chrome/browser/ui/views/frame/browser_view.h

index eea2b4858e170bbafe8a0ad76352568f3a3ca52b..a70d8bdd97acb807c063f9033fd20d1cad55cf39 100644

--- a/chrome/browser/ui/views/frame/browser_view.h

+++ b/chrome/browser/ui/views/frame/browser_view.h

@@ -232,10 +232,6 @@ class BrowserView : public BrowserWindow,

// Only exiting fullscreen in this way is currently supported.

void FullscreenStateChanged();

- // Called from BookmarkBarView/DownloadShelfView during their show/hide

- // animations.

- void ToolbarSizeChanged(bool is_animating);

// Overridden from BrowserWindow:

void Show() override;

void ShowInactive() override;

@@ -293,6 +289,7 @@ class BrowserView : public BrowserWindow,

void UpdateToolbar(content::WebContents* contents) override;

void ResetToolbarTabState(content::WebContents* contents) override;

void FocusToolbar() override;

+ void ToolbarSizeChanged(bool is_animating) override;

void FocusAppMenu() override;

void FocusBookmarksToolbar() override;

void FocusInfobars() override;