chrome/browser/ui/extensions/bookmark_app_browsertest.cc - Issue 1036173002: Animate showing / hiding the location bar for bookmark apps.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/extensions/bookmark_app_browsertest.cc

Issue 1036173002: Animate showing / hiding the location bar for bookmark apps. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Mac compile Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/extensions/bookmark_app_browser_controller.cc ('K') | « chrome/browser/ui/extensions/bookmark_app_browser_controller.cc ('k') | chrome/browser/ui/location_bar/location_bar.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/extensions/bookmark_app_browsertest.cc

diff --git a/chrome/browser/ui/extensions/bookmark_app_browsertest.cc b/chrome/browser/ui/extensions/bookmark_app_browsertest.cc

index be61abf9e1b766692a24836f202ec8d389457f3b..186029b026c89fdaefa84bdb1f604276ca44cee4 100644

--- a/chrome/browser/ui/extensions/bookmark_app_browsertest.cc

+++ b/chrome/browser/ui/extensions/bookmark_app_browsertest.cc

@@ -14,6 +14,7 @@

#include "chrome/browser/ui/browser_iterator.h"

#include "chrome/browser/ui/extensions/app_launch_params.h"

#include "chrome/browser/ui/extensions/application_launch.h"

+#include "chrome/browser/ui/extensions/bookmark_app_browser_controller.h"

#include "chrome/browser/ui/tabs/tab_strip_model.h"

#include "chrome/browser/web_applications/web_app.h"

#include "chrome/common/chrome_switches.h"

@@ -39,7 +40,7 @@ void NavigateAndCheckForLocationBar(Browser* browser,

GURL url(url_string);

ui_test_utils::NavigateToURL(browser, url);

EXPECT_EQ(expected_visibility,

- browser->SupportsWindowFeature(Browser::FEATURE_LOCATIONBAR));

+ browser->bookmark_app_controller()->ShouldShowLocationBar());

}

} // namespace