Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2713)

Unified Diff: chrome/browser/ui/browser.h

Issue 1036173002: Animate showing / hiding the location bar for bookmark apps. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix stuffup Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/extension_ui_util.cc ('k') | chrome/browser/ui/browser.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/browser.h
diff --git a/chrome/browser/ui/browser.h b/chrome/browser/ui/browser.h
index fcb711cfac89b6cff6adb5712cd81c1ba3b758ff..b5b87800958282369564e987f391efce1214af85 100644
--- a/chrome/browser/ui/browser.h
+++ b/chrome/browser/ui/browser.h
@@ -81,6 +81,7 @@ class SessionStorageNamespace;
}
namespace extensions {
+class BookmarkAppBrowserController;
class Extension;
class ExtensionRegistry;
class WindowController;
@@ -282,6 +283,9 @@ class Browser : public TabStripModelObserver,
BrowserInstantController* instant_controller() {
return instant_controller_.get();
}
+ extensions::BookmarkAppBrowserController* bookmark_app_controller() {
+ return bookmark_app_controller_.get();
+ }
// Get the FindBarController for this browser, creating it if it does not
// yet exist.
@@ -799,6 +803,10 @@ class Browser : public TabStripModelObserver,
// Shared code between Reload() and ReloadIgnoringCache().
void ReloadInternal(WindowOpenDisposition disposition, bool ignore_cache);
+ // Returns true if the Browser window supports a location bar. Having support
+ // for the location bar does not mean it will be visible.
+ bool SupportsLocationBar() const;
+
// Returns true if the Browser window should show the location bar.
bool ShouldShowLocationBar() const;
@@ -956,6 +964,9 @@ class Browser : public TabStripModelObserver,
scoped_ptr<BrowserInstantController> instant_controller_;
+ // Helper which handles bookmark app specific browser configuration.
+ scoped_ptr<extensions::BookmarkAppBrowserController> bookmark_app_controller_;
+
BookmarkBar::State bookmark_bar_state_;
scoped_ptr<ExclusiveAccessManager> exclusive_access_manager_;
« no previous file with comments | « chrome/browser/extensions/extension_ui_util.cc ('k') | chrome/browser/ui/browser.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698