Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(530)

Issue 1036143003: Revert "webrtc: Fixes WebRtcBrowserTest to use DOM attributes correctly." (Closed)

Created:
5 years, 9 months ago by perkj_chrome
Modified:
5 years, 9 months ago
Reviewers:
phoglund_chromium
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "webrtc: Fixes WebRtcBrowserTest to use DOM attributes correctly." This reverts commit e27865b72eab201b557a60b88bb648e3f8b0843f. The original cl https://codereview.chromium.org/904823002/. Reason for revert: It is no longer needed since RTCSessionDescription and RTCIceCandidate can now be serialized. See https://src.chromium.org/viewvc/blink?revision=192621&view=revision. BUG=471132 Committed: https://crrev.com/449e7155938a1229dd51a569a7519b27948910bc Cr-Commit-Position: refs/heads/master@{#322560}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -26 lines) Patch
M chrome/test/data/webrtc/peerconnection.js View 5 chunks +4 lines, -26 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
perkj_chrome
please?
5 years, 9 months ago (2015-03-27 11:04:15 UTC) #2
phoglund_chromium
lgtm
5 years, 9 months ago (2015-03-27 12:13:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1036143003/1
5 years, 9 months ago (2015-03-27 12:13:42 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-27 12:17:21 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-27 12:18:46 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/449e7155938a1229dd51a569a7519b27948910bc
Cr-Commit-Position: refs/heads/master@{#322560}

Powered by Google App Engine
This is Rietveld 408576698