Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issue 1036133005: Fix libdl dependency on Android and remove librt hack. (Closed)

Created:
5 years, 8 months ago by rmcilroy
Modified:
5 years, 8 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix libdl dependency on Android and remove librt hack. The libdl library is already included on target builds of Android and needs to be added to the build command line with a particular order to avoid undefined references in other libraries. Fix this by only explicitly including it in host builds and relying on the implicit inclusion on target builds. Also remove the librt hack which is not longer necessary due to the AOSP build bot having been removed. BUG=chromium:469973 LOG=Y Committed: https://crrev.com/11c4e2f2f7fe4f355b0e608b3a0babc2def48782 Cr-Commit-Position: refs/heads/master@{#27535}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -55 lines) Patch
M BUILD.gn View 1 chunk +3 lines, -5 lines 0 comments Download
M src/base/platform/condition-variable.cc View 2 chunks +2 lines, -8 lines 0 comments Download
M src/base/platform/time.cc View 3 chunks +2 lines, -11 lines 0 comments Download
M src/perf-jit.h View 1 chunk +0 lines, -7 lines 0 comments Download
M tools/gyp/v8.gyp View 2 chunks +11 lines, -24 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
rmcilroy
jochen for libdl fix bmeurer for librt hack removal jarin as FYI for perf-jit comment ...
5 years, 8 months ago (2015-03-31 11:23:14 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1036133005/1
5 years, 8 months ago (2015-03-31 11:24:18 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/1638)
5 years, 8 months ago (2015-03-31 11:28:33 UTC) #6
jochen (gone - plz use gerrit)
lgtm
5 years, 8 months ago (2015-03-31 11:31:25 UTC) #7
Jarin
looks great. thanks.
5 years, 8 months ago (2015-03-31 11:43:17 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1036133005/1
5 years, 8 months ago (2015-03-31 12:00:58 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-03-31 12:08:17 UTC) #11
commit-bot: I haz the power
5 years, 8 months ago (2015-03-31 12:08:33 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/11c4e2f2f7fe4f355b0e608b3a0babc2def48782
Cr-Commit-Position: refs/heads/master@{#27535}

Powered by Google App Engine
This is Rietveld 408576698