Issue 103613005: Make arguments to Node methods non-optional

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 103613005: Make arguments to Node methods non-optional (Closed)

Created:
7 years ago by philipj_slow

Modified:
7 years ago

Reviewers:
jochen (gone - plz use gerrit)

CC:
blink-reviews, arv+blink, eae+blinkwatch, dglazkov+blink, adamk+blink_chromium.org, watchdog-blink-watchlist_google.com, Inactive

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

Make arguments to Node methods non-optional http://dom.spec.whatwg.org/#interface-node Only touch methods defined by the above spec. The added missing-arguments test passes in Firefox Nightly, IE11 Release Preview and Opera 12.16, so there ought to be fairly little Web content depending on the old behavior. BUG=325922 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=163349

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+71 lines, -8 lines)			Patch
A	LayoutTests/fast/dom/Node/missing-arguments.html	View	1 chunk	+29 lines, -0 lines	0 comments	Download
A	LayoutTests/fast/dom/Node/missing-arguments-expected.txt	View	1 chunk	+34 lines, -0 lines	0 comments	Download
M	Source/core/dom/Node.idl	View	2 chunks	+8 lines, -8 lines	0 comments	Download

Total messages: 4 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/103613005/1

7 years ago (2013-12-06 14:52:09 UTC) #3

Message was sent while issue was closed.

Change committed as 163349