Minor fixes to junit and robolectric BUILD.gn files.

Minor fixes to junit and robolectric BUILD.gn files.

BUG=

Committed: https://crrev.com/3c7961f35b4c125cb3e2d44a678938847beeebf4
Cr-Commit-Position: refs/heads/master@{#322508}

[mikecase (-- gone --), 2015-03-26 23:03:42]

mikecase@chromium.org changed reviewers:
+ cjhopman@chromium.org, jbudorick@chromium.org, tedchoc@chromium.org

[mikecase (-- gone --), 2015-03-26 23:03:43]

+ jbudorick for third_party/*
+ tedchoc for testing/android/*
+ cjhopman for build files.

Fixes to some BUILD.gn files I made. Basically need to add "testonly = true" to
a couple of test build targets and need to remove "visibility = [ ":*" ]" from
the robolectric BUILD.gn as the java_prebuilt template doesn't work properly
with it.


You get this error from the "visibility" option by the way...

ERROR at //third_party/robolectric/BUILD.gn:9:16: Assignment had no effect.
  visibility = [ ":*" ]
               ^------
You set the variable "visibility" here and it was unused before it went
out of scope.

[Ted C, 2015-03-26 23:34:03]

On 2015/03/26 23:03:43, mikecase wrote:
> + jbudorick for third_party/*
> + tedchoc for testing/android/*
> + cjhopman for build files.
> 
> Fixes to some BUILD.gn files I made. Basically need to add "testonly = true"
to
> a couple of test build targets and need to remove "visibility = [ ":*" ]" from
> the robolectric BUILD.gn as the java_prebuilt template doesn't work properly
> with it.
> 
> 
> You get this error from the "visibility" option by the way...
> 
> ERROR at //third_party/robolectric/BUILD.gn:9:16: Assignment had no effect.
>   visibility = [ ":*" ]
>                ^------
> You set the variable "visibility" here and it was unused before it went
> out of scope.

owners - lgtm

[cjhopman, 2015-03-26 23:56:45]

lgtm

[jbudorick, 2015-03-26 23:57:33]

On 2015/03/26 23:56:45, cjhopman wrote:
> lgtm

rslgtm for third_party/junit/ and third_party/robolectric

[jbudorick, 2015-03-26 23:57:45]

On 2015/03/26 23:57:33, jbudorick wrote:
> On 2015/03/26 23:56:45, cjhopman wrote:
> > lgtm
> 
> rslgtm for third_party/junit/ and third_party/robolectric

rather, rs lgtm

[mikecase (-- gone --), 2015-03-26 23:57:57]

The CQ bit was checked by mikecase@chromium.org

[commit-bot: I haz the power, 2015-03-26 23:58:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1036093002/1

[commit-bot: I haz the power, 2015-03-27 00:26:21]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-03-27 00:27:01]

Patchset 1 (id:??) landed as
https://crrev.com/3c7961f35b4c125cb3e2d44a678938847beeebf4
Cr-Commit-Position: refs/heads/master@{#322508}