Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Issue 1036073002: Replace linux-specific code in test scripts. (Closed)

Created:
5 years, 9 months ago by Tom Sepez
Modified:
5 years, 9 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Replace linux-specific code in test scripts. Now that there's a win bot, this needs to be more careful. R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/84e50d58496622af351cd27da51479059736923d

Patch Set 1 #

Patch Set 2 : fix line wrap and remove unused executable arg #

Patch Set 3 : Use sys.executable #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -6 lines) Patch
M testing/tools/run_corpus_tests.py View 2 chunks +2 lines, -1 line 0 comments Download
M testing/tools/run_javascript_tests.py View 1 2 4 chunks +6 lines, -4 lines 0 comments Download
M testing/tools/run_pixel_tests.py View 1 2 1 chunk +1 line, -1 line 0 comments Download
A testing/tools/text_diff.py View 1 1 chunk +32 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Tom Sepez
Lei, please review. Thanks.
5 years, 9 months ago (2015-03-26 22:04:02 UTC) #2
Lei Zhang
Can we use sys.executable in place of 'python' ?
5 years, 9 months ago (2015-03-26 22:59:28 UTC) #3
Tom Sepez
On 2015/03/26 22:59:28, Lei Zhang wrote: > Can we use sys.executable in place of 'python' ...
5 years, 9 months ago (2015-03-26 23:24:57 UTC) #4
Lei Zhang
lgtm
5 years, 9 months ago (2015-03-26 23:28:44 UTC) #5
Tom Sepez
5 years, 9 months ago (2015-03-26 23:29:12 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
84e50d58496622af351cd27da51479059736923d (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698