MEDIASUBTYPE_RGB32 support for Windows

This CL adds support for MEDIASUBTYPE_RGB32 in Windows platform.

MEDIASUBTYPE_RGB32 is observed to be equivalent to MEDIASUBTYPE_ARGB32 in terms of color space conversion. This CL adds support for this sub type by directing it to PIXEL_FORMAT_ARGB VideoPixelFormat. It is also observed that output is flipped as it happens on PIXEL_FORMAT_RGB24 [0]. This is solved by adding a Windows specific flip switch.

[0] https://code.google.com/p/chromium/codesearch#chromium/src/content/browser/renderer_host/media/video_capture_device_client.cc&l=156

BUG=464855
BUG=389542
TEST=AppRTC loopback was tested with DXTory capturing on Solitaire.

Committed: https://crrev.com/fd97d7dcce06c31744a9f5eaf06239650daadfc8
Cr-Commit-Position: refs/heads/master@{#322687}

[emircan, 2015-03-26 23:08:32]

emircan@chromium.org changed reviewers:
+ mcasas@chromium.org, perkj@chromium.org

[emircan, 2015-03-26 23:08:44]

Please take a look.

[mcasas, 2015-03-27 01:02:11]

https://codereview.chromium.org/1036063002/diff/1/content/browser/renderer_ho...
File content/browser/renderer_host/media/video_capture_device_client.cc (right):

https://codereview.chromium.org/1036063002/diff/1/content/browser/renderer_ho...
content/browser/renderer_host/media/video_capture_device_client.cc:167: flip =
true;
Please be sure that devices using PIXEL_FORMAT_ARGB, i.e.
those reporting MEDIASUBTYPE_ARGB32 in [1],  are OK with
this extra flipping.

[1]
https://code.google.com/p/chromium/codesearch#chromium/src/media/video/captur...

https://codereview.chromium.org/1036063002/diff/1/media/video/capture/win/sin...
File media/video/capture/win/sink_input_pin_win.cc (right):

https://codereview.chromium.org/1036063002/diff/1/media/video/capture/win/sin...
media/video/capture/win/sink_input_pin_win.cc:157: pvi->bmiHeader.biCompression
== BI_RGB) {
Indent two extra right

https://codereview.chromium.org/1036063002/diff/1/media/video/capture/win/sin...
media/video/capture/win/sink_input_pin_win.cc:159: return true;  // This format
is acceptable.
Comment is irrelevant (similar ones too).

[emircan, 2015-03-27 17:49:36]

Patchset #3 (id:40001) has been deleted

[emircan, 2015-03-27 17:50:39]

Please take a look.

https://codereview.chromium.org/1036063002/diff/1/content/browser/renderer_ho...
File content/browser/renderer_host/media/video_capture_device_client.cc (right):

https://codereview.chromium.org/1036063002/diff/1/content/browser/renderer_ho...
content/browser/renderer_host/media/video_capture_device_client.cc:167: flip =
true;
On 2015/03/27 01:02:11, mcasas wrote:
> Please be sure that devices using PIXEL_FORMAT_ARGB, i.e.
> those reporting MEDIASUBTYPE_ARGB32 in [1],  are OK with
> this extra flipping.
> 
> [1]
>
https://code.google.com/p/chromium/codesearch#chromium/src/media/video/captur...

I see your concern. In order to not change the existing workflow for
PIXEL_FORMAT_ARGB, I defined PIXEL_FORMAT_RGB32 with the same colorspace
conversion and flip.

https://codereview.chromium.org/1036063002/diff/1/media/video/capture/win/sin...
File media/video/capture/win/sink_input_pin_win.cc (right):

https://codereview.chromium.org/1036063002/diff/1/media/video/capture/win/sin...
media/video/capture/win/sink_input_pin_win.cc:157: pvi->bmiHeader.biCompression
== BI_RGB) {
On 2015/03/27 01:02:11, mcasas wrote:
> Indent two extra right

Done.

https://codereview.chromium.org/1036063002/diff/1/media/video/capture/win/sin...
media/video/capture/win/sink_input_pin_win.cc:159: return true;  // This format
is acceptable.
On 2015/03/27 01:02:11, mcasas wrote:
> Comment is irrelevant (similar ones too).

Done.

[mcasas, 2015-03-27 18:23:53]

LGTM modulo my suggestions. Bots plz.

https://codereview.chromium.org/1036063002/diff/60001/content/browser/rendere...
File content/browser/renderer_host/media/video_capture_device_client.cc (right):

https://codereview.chromium.org/1036063002/diff/60001/content/browser/rendere...
content/browser/renderer_host/media/video_capture_device_client.cc:169: break;
What about:

case media::PIXEL_FORMAT_RGB32:  
// Fallback to PIXEL_FORMAT_ARGB setting |flip| in Windows platforms.
#if defined(OS_WIN)
  flip = true;
#endif

and letting it fall through?

[emircan, 2015-03-27 19:26:51]

Patchset #3 (id:60001) has been deleted

[emircan, 2015-03-27 19:27:02]

Thanks. Bots were done on Patch Set #2.

[emircan, 2015-03-27 19:27:35]

The CQ bit was checked by emircan@chromium.org

[emircan, 2015-03-27 19:27:36]

The patchset sent to the CQ was uploaded after l-g-t-m from mcasas@chromium.org
Link to the patchset: https://codereview.chromium.org/1036063002/#ps80001
(title: "Fallback in switch statement.")

[commit-bot: I haz the power, 2015-03-27 19:27:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1036063002/80001

[commit-bot: I haz the power, 2015-03-27 19:36:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-27 19:37:02]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[emircan, 2015-03-27 20:26:50]

emircan@chromium.org changed reviewers:
+ dalecurtis@chromium.org

[emircan, 2015-03-27 20:26:51]

I still need owners review for /media/base/*

dalecurtis@ can you please take a look at /media/base/*

[DaleCurtis, 2015-03-28 00:21:33]

lgtm

[emircan, 2015-03-28 00:36:39]

The CQ bit was checked by emircan@chromium.org

[commit-bot: I haz the power, 2015-03-28 00:36:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1036063002/80001

[commit-bot: I haz the power, 2015-03-28 00:40:06]

Committed patchset #3 (id:80001)

[commit-bot: I haz the power, 2015-03-28 00:40:34]

Patchset 3 (id:??) landed as
https://crrev.com/fd97d7dcce06c31744a9f5eaf06239650daadfc8
Cr-Commit-Position: refs/heads/master@{#322687}