extensions/browser/api/networking_private/networking_private_api.cc - Issue 1036033002: Add types to networkigPrivate IDL

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/networking_private/networking_private_api.cc

Issue 1036033002: Add types to networkigPrivate IDL (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@issue_470262_networking_private_idl_1

Patch Set: Feedback, Fix and add some types Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/test/data/extensions/api_test/networking_private/chromeos/test.js ('K') | « chrome/test/data/extensions/api_test/networking_private/chromeos/test.js ('k') | extensions/common/api/networking_private.idl » ('j') | extensions/common/api/networking_private.idl » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/api/networking_private/networking_private_api.cc

diff --git a/extensions/browser/api/networking_private/networking_private_api.cc b/extensions/browser/api/networking_private/networking_private_api.cc

index 8a8da965ede9961a41d1d83ca91f5da104f6121c..92270e905f94cd65367e26bb4c6afa04c6f2a1e1 100644

--- a/extensions/browser/api/networking_private/networking_private_api.cc

+++ b/extensions/browser/api/networking_private/networking_private_api.cc

@@ -146,10 +146,8 @@ bool NetworkingPrivateSetPropertiesFunction::RunAsync() {

private_api::SetProperties::Params::Create(*args_);

EXTENSION_FUNCTION_VALIDATE(params);

- // TODO(stevenjb): Switch this back to params->properties.ToValue() once we

- // introduce types to the IDL. crbug.com/470262.

scoped_ptr<base::DictionaryValue> properties_dict(

- params->properties.additional_properties.DeepCopy());

+ params->properties.ToValue());

GetDelegate(browser_context())

->SetProperties(

@@ -180,10 +178,8 @@ bool NetworkingPrivateCreateNetworkFunction::RunAsync() {

private_api::CreateNetwork::Params::Create(*args_);