Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 1036023002: Move remaining QUIC server files from net/quic/ to net/tools/quic/. (Closed)

Created:
5 years, 9 months ago by Ryan Hamilton
Modified:
5 years, 9 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move remaining QUIC server files from net/quic/ to net/tools/quic/. Add targets for epoll and chromium versions of the QUIC client and server. Committed: https://crrev.com/216445cb5b5e14daa7d0126b01d878a7a11605d4 Cr-Commit-Position: refs/heads/master@{#322507}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Fix GN and Windows #

Patch Set 3 : components/cronet.gypi #

Patch Set 4 : correctly fix cronet #

Unified diffs Side-by-side diffs Delta from patch set Stats (+182 lines, -882 lines) Patch
M components/cronet.gypi View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M net/BUILD.gn View 1 9 chunks +39 lines, -41 lines 0 comments Download
M net/net.gyp View 8 chunks +26 lines, -34 lines 0 comments Download
M net/net.gypi View 2 chunks +1 line, -1 line 0 comments Download
D net/quic/quic_per_connection_packet_writer.h View 1 chunk +0 lines, -53 lines 0 comments Download
D net/quic/quic_per_connection_packet_writer.cc View 1 chunk +0 lines, -58 lines 0 comments Download
D net/quic/quic_server.h View 1 chunk +0 lines, -124 lines 0 comments Download
D net/quic/quic_server.cc View 1 chunk +0 lines, -221 lines 0 comments Download
D net/quic/quic_server_bin.cc View 1 chunk +0 lines, -74 lines 0 comments Download
D net/quic/quic_server_packet_writer.h View 1 chunk +0 lines, -74 lines 0 comments Download
D net/quic/quic_server_packet_writer.cc View 1 chunk +0 lines, -97 lines 0 comments Download
A + net/tools/quic/quic_server_bin.cc View 1 3 chunks +6 lines, -6 lines 0 comments Download
A + net/tools/quic/quic_simple_per_connection_packet_writer.h View 2 chunks +14 lines, -11 lines 0 comments Download
A + net/tools/quic/quic_simple_per_connection_packet_writer.cc View 2 chunks +14 lines, -12 lines 0 comments Download
A + net/tools/quic/quic_simple_server.h View 4 chunks +18 lines, -18 lines 0 comments Download
A + net/tools/quic/quic_simple_server.cc View 14 chunks +24 lines, -24 lines 0 comments Download
A + net/tools/quic/quic_simple_server_bin.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
A + net/tools/quic/quic_simple_server_packet_writer.h View 3 chunks +13 lines, -10 lines 0 comments Download
A + net/tools/quic/quic_simple_server_packet_writer.cc View 7 chunks +18 lines, -14 lines 0 comments Download
A + net/tools/quic/quic_simple_server_test.cc View 1 5 chunks +5 lines, -6 lines 0 comments Download

Messages

Total messages: 28 (14 generated)
Ryan Hamilton
I think this is the last one!
5 years, 9 months ago (2015-03-26 17:47:56 UTC) #2
ramant (doing other things)
LGTM. https://codereview.chromium.org/1036023002/diff/1/net/tools/quic/quic_server_bin.cc File net/tools/quic/quic_server_bin.cc (right): https://codereview.chromium.org/1036023002/diff/1/net/tools/quic/quic_server_bin.cc#newcode73 net/tools/quic/quic_server_bin.cc:73: } nit: should we have return 0 at ...
5 years, 9 months ago (2015-03-26 18:09:24 UTC) #3
Ryan Hamilton
Thanks! https://codereview.chromium.org/1036023002/diff/1/net/tools/quic/quic_server_bin.cc File net/tools/quic/quic_server_bin.cc (right): https://codereview.chromium.org/1036023002/diff/1/net/tools/quic/quic_server_bin.cc#newcode73 net/tools/quic/quic_server_bin.cc:73: } On 2015/03/26 18:09:24, ramant wrote: > nit: ...
5 years, 9 months ago (2015-03-26 18:59:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1036023002/1
5 years, 9 months ago (2015-03-26 20:26:41 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_dbg on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_dbg/builds/55752) android_chromium_gn_compile_rel on tryserver.chromium.linux (JOB_FAILED, ...
5 years, 9 months ago (2015-03-26 20:33:43 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1036023002/20001
5 years, 9 months ago (2015-03-26 22:09:08 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: android_compile_dbg on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_compile_dbg/builds/872)
5 years, 9 months ago (2015-03-26 22:17:08 UTC) #13
Ryan Hamilton
mmenke: cronet.gypi OWNERS, please
5 years, 9 months ago (2015-03-26 23:00:39 UTC) #16
mmenke
On 2015/03/26 23:00:39, Ryan Hamilton wrote: > mmenke: cronet.gypi OWNERS, please cronet LGTM
5 years, 9 months ago (2015-03-26 23:01:24 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1036023002/60001
5 years, 9 months ago (2015-03-26 23:02:02 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg_recipe on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_dbg_recipe/builds/61046) android_compile_dbg on tryserver.chromium.linux (JOB_FAILED, ...
5 years, 9 months ago (2015-03-26 23:10:44 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1036023002/100001
5 years, 9 months ago (2015-03-26 23:31:07 UTC) #26
commit-bot: I haz the power
Committed patchset #4 (id:100001)
5 years, 9 months ago (2015-03-27 00:23:38 UTC) #27
commit-bot: I haz the power
5 years, 9 months ago (2015-03-27 00:24:18 UTC) #28
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/216445cb5b5e14daa7d0126b01d878a7a11605d4
Cr-Commit-Position: refs/heads/master@{#322507}

Powered by Google App Engine
This is Rietveld 408576698